From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc: jack@suse.de, flole@flole.de
Subject: Re: [PATCH] NFSD: Protect against filesystem freezing
Date: Mon, 06 Mar 2023 17:57:53 -0500 [thread overview]
Message-ID: <ac05071a4a9dee6f249945d23e37812aa350fcc5.camel@kernel.org> (raw)
In-Reply-To: <167811742782.1909.380332356774647144.stgit@bazille.1015granger.net>
On Mon, 2023-03-06 at 10:43 -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> Flole observes this WARNING on occasion:
>
> [1210423.486503] WARNING: CPU: 8 PID: 1524732 at fs/ext4/ext4_jbd2.c:75 ext4_journal_check_start+0x68/0xb0
>
> Reported-by: <flole@flole.de>
> Suggested-by: Jan Kara <jack@suse.cz>
> Link: https://bugzilla.kernel.org/show_bug.cgi?id=217123
> Fixes: 73da852e3831 ("nfsd: use vfs_iter_read/write")
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/vfs.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> index 21d5209f6e04..ba34a31a7c70 100644
> --- a/fs/nfsd/vfs.c
> +++ b/fs/nfsd/vfs.c
> @@ -1104,7 +1104,9 @@ nfsd_vfs_write(struct svc_rqst *rqstp, struct svc_fh *fhp, struct nfsd_file *nf,
> since = READ_ONCE(file->f_wb_err);
> if (verf)
> nfsd_copy_write_verifier(verf, nn);
> + file_start_write(file);
> host_err = vfs_iter_write(file, &iter, &pos, flags);
> + file_end_write(file);
> if (host_err < 0) {
> nfsd_reset_write_verifier(nn);
> trace_nfsd_writeverf_reset(nn, rqstp, host_err);
>
>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-03-06 22:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 15:43 [PATCH] NFSD: Protect against filesystem freezing Chuck Lever
2023-03-06 16:16 ` Jan Kara
2023-03-06 22:57 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ac05071a4a9dee6f249945d23e37812aa350fcc5.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=flole@flole.de \
--cc=jack@suse.de \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox