Re: [patch 03/29] knfsd: add userspace controls for stats tables

[Greg Banks <gnb-xTcybq6BZ68@public.gmane.org>]

On Sun, Apr 26, 2009 at 7:57 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
> On Wed, Apr 01, 2009 at 07:28:03AM +1100, Greg Banks wrote:

>> +
>> +/**
>> + * write_stats_prune_period - Set or report the period for pruning
>> + *                         old per-client/per-export stats entries,
>> + *                         in seconds.
>> + *
>> + * Input:
>> + *                   buf:            ignored
>> + *                   size:           zero
>> + *
>> + * OR
>> + *
>> + * Input:
>> + *                   buf:            C string containing an unsigned
>> + *                                   integer value representing the new value
>> + *                   size:           non-zero length of C string in @buf
>> + * Output:
>> + *   On success:     passed-in buffer filled with '\n'-terminated C string
>> + *                   containing numeric value of the current setting
>> + *                   return code is the size in bytes of the string
>> + *   On error:       return code is zero or a negative errno value
>> + */
>
> Just an idle remark, don't worry about this for now, but: we might want
> to rein in this write_*() comment format a little some day.  A lot of
> the content seems duplicated.
>

Fair comment.  Noted for later.

-- 
Greg.