From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0F0CF2EFD9B;
	Thu,  9 Apr 2026 05:52:10 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.137.202.133
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1775713932; cv=none; b=uehxWHzvN8TRPKjai3+c/BMDSd21nEFOtMibGHjTQIbwCjmZK5HBiE2MEZ7IoT9FvqkiZnFzIWatCN/oHppxDDFiD3nxgsjM6Jcxd3u5dbQuxTGH6PsGqNTLL5XxDQ0wngL1AwMc7IM8iQUx/rYeWPltvCeVnCXo+DnJEXi1Iaw=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1775713932; c=relaxed/simple;
	bh=5Xl4Hr/rdTir2fplfAqw/LyqeA62MFdfk/YPVfXWUOc=;
	h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:
	 Content-Type:Content-Disposition:In-Reply-To; b=bweDFsJRynppxgPtpDpKPpXBJTtQMEQSVs5vgUbvw6aqgZ+/odPm0VOdelyzLyjPTjJiD+PAL3ZdMnoGI56EQJnm3GighfG70y4fH4/fYnBDitwVPqN0MVSUo7R8pPy5HsufF4+IZlX8sZ1kYECk8UZTt7eEdGujIQjb/mlE3/Y=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org; dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b=GjImWanb; arc=none smtp.client-ip=198.137.202.133
Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=infradead.org
Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bombadil.srs.infradead.org
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="GjImWanb"
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
	d=infradead.org; s=bombadil.20210309; h=In-Reply-To:Content-Type:MIME-Version
	:References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
	Content-Transfer-Encoding:Content-ID:Content-Description;
	bh=UMroIp8osf38V3IaXClZpIfCVNsX2ssW6flgtrb+9PY=; b=GjImWanbIMK7nXuK5qKZSCtrNE
	oNnVSH3OUkvo5CX6JHlhy9ixgbdGUCQwaA1pC9QGZ4AJv+dsPYFwiIGMqEJiUqENHJ0mikyyM6Aqu
	ewutJGNUyP7Jk6QPTYBtFP0B4JXTqq0HokRr+jlOtWHGTJE9cCHVfoCU5Gw4eEz2ksWFOrEH2s388
	N0PizmOjfL4IUgBj9V9IvZAGz3iYLWoG/HiXuhrZLaq9NvNgPUO8I+vQs2+Ykiot1iQ82dTAqInPO
	mLoku86KJ3xFzEFOCO2HxlsYTVS/hZh4ayPfmdWxG3V777kCJpiLpIWSSmxHBl9MoPMye8V8MqJoH
	L7kHjjnQ==;
Received: from hch by bombadil.infradead.org with local (Exim 4.98.2 #2 (Red Hat Linux))
	id 1wAiJD-00000009jZf-1UIA;
	Thu, 09 Apr 2026 05:52:07 +0000
Date: Wed, 8 Apr 2026 22:52:07 -0700
From: Christoph Hellwig <hch@infradead.org>
To: Ritesh Harjani <ritesh.list@gmail.com>
Cc: Jeff Layton <jlayton@kernel.org>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Christian Brauner <brauner@kernel.org>, Jan Kara <jack@suse.cz>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	David Hildenbrand <david@kernel.org>,
	Lorenzo Stoakes <ljs@kernel.org>,
	"Liam R. Howlett" <Liam.Howlett@oracle.com>,
	Vlastimil Babka <vbabka@kernel.org>,
	Mike Rapoport <rppt@kernel.org>,
	Suren Baghdasaryan <surenb@google.com>,
	Michal Hocko <mhocko@suse.com>, Mike Snitzer <snitzer@kernel.org>,
	Jens Axboe <axboe@kernel.dk>, Chuck Lever <chuck.lever@oracle.com>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-nfs@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH v2 1/3] mm: kick writeback flusher instead of inline
 flush for IOCB_DONTCACHE
Message-ID: <adc-h4bhUFGqbejN@infradead.org>
References: <20260408-dontcache-v2-0-948dec1e756b@kernel.org>
 <20260408-dontcache-v2-1-948dec1e756b@kernel.org>
 <tstklxm7.ritesh.list@gmail.com>
Precedence: bulk
X-Mailing-List: linux-nfs@vger.kernel.org
List-Id: <linux-nfs.vger.kernel.org>
List-Subscribe: <mailto:linux-nfs+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-nfs+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <tstklxm7.ritesh.list@gmail.com>
X-SRS-Rewrite: SMTP reverse-path rewritten from <hch@infradead.org> by bombadil.infradead.org. See http://www.infradead.org/rpr.html

On Thu, Apr 09, 2026 at 07:10:32AM +0530, Ritesh Harjani wrote:
> > +void filemap_dontcache_kick_writeback(struct address_space *mapping)
> 
> This api gives a wrong sense that we are kicking writeback to write
> dirty pages which belongs to only this inode's address space mapping.
> But instead we are starting wb for everything on the respective bdi.
> 
> So instead why not just export symbol for wakeup_flusher_threads_bdi()
> and use it instead?

I'd rather not expose that to wide with the extra reason arguments
that's not otherwise exposed outside the core writeback code.

Btw, wakeup_flusher_threads_bdi should really be marked static in
fs-writeback.c as well.