From: Jeff Layton <jlayton@kernel.org>
To: trondmy@kernel.org, linux-nfs@vger.kernel.org
Cc: Josef Bacik <josef@toxicpanda.com>
Subject: Re: [PATCH v2 1/4] SUNRPC: rpcbind should never reset the port to the value '0'
Date: Tue, 25 Mar 2025 13:56:15 -0400 [thread overview]
Message-ID: <ae9b5632cd01a409b08446854997b52401c21980.camel@kernel.org> (raw)
In-Reply-To: <8b9a709ef321aa246b9ef00a8bcfa71a77df4245.1742919341.git.trond.myklebust@hammerspace.com>
On Tue, 2025-03-25 at 12:17 -0400, trondmy@kernel.org wrote:
> From: Trond Myklebust <trond.myklebust@hammerspace.com>
>
> If we already had a valid port number for the RPC service, then we
> should not allow the rpcbind client to set it to the invalid value '0'.
>
> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
> ---
> net/sunrpc/rpcb_clnt.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/rpcb_clnt.c b/net/sunrpc/rpcb_clnt.c
> index 102c3818bc54..53bcca365fb1 100644
> --- a/net/sunrpc/rpcb_clnt.c
> +++ b/net/sunrpc/rpcb_clnt.c
> @@ -820,9 +820,10 @@ static void rpcb_getport_done(struct rpc_task *child, void *data)
> }
>
> trace_rpcb_setport(child, map->r_status, map->r_port);
> - xprt->ops->set_port(xprt, map->r_port);
> - if (map->r_port)
> + if (map->r_port) {
> + xprt->ops->set_port(xprt, map->r_port);
> xprt_set_bound(xprt);
> + }
> }
>
> /*
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2025-03-25 17:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-25 16:17 [PATCH v2 0/4] Ensure that ENETUNREACH terminates state recovery trondmy
2025-03-25 16:17 ` [PATCH v2 1/4] SUNRPC: rpcbind should never reset the port to the value '0' trondmy
2025-03-25 17:56 ` Jeff Layton [this message]
2025-03-25 16:17 ` [PATCH v2 2/4] SUNRPC: rpc_clnt_set_transport() must not change the autobind setting trondmy
2025-03-25 17:55 ` Jeff Layton
2025-03-25 16:17 ` [PATCH v2 3/4] NFSv4: clp->cl_cons_state < 0 signifies an invalid nfs_client trondmy
2025-03-25 17:59 ` Jeff Layton
2025-03-25 18:48 ` Trond Myklebust
2025-03-25 19:44 ` Jeff Layton
2025-03-25 20:30 ` Trond Myklebust
2025-03-25 16:17 ` [PATCH v2 4/4] NFSv4: Treat ENETUNREACH errors as fatal for state recovery trondmy
2025-03-25 18:04 ` Jeff Layton
2025-03-25 18:50 ` Trond Myklebust
2025-03-25 19:26 ` Jeff Layton
2025-03-25 19:40 ` Concerns about ENETUNREACH patch series Re: [PATCH v2 0/4] Ensure that ENETUNREACH terminates " Lionel Cons
2025-03-25 20:42 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ae9b5632cd01a409b08446854997b52401c21980.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=josef@toxicpanda.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox