From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F231EC5B578 for ; Wed, 3 Jul 2019 08:18:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0D792184C for ; Wed, 3 Jul 2019 08:18:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727046AbfGCISS (ORCPT ); Wed, 3 Jul 2019 04:18:18 -0400 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:26565 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727045AbfGCISS (ORCPT ); Wed, 3 Jul 2019 04:18:18 -0400 X-IronPort-AV: E=Sophos;i="5.63,446,1557180000"; d="scan'208";a="312254589" Received: from vaio-julia.rsr.lip6.fr ([132.227.76.33]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 10:18:16 +0200 Date: Wed, 3 Jul 2019 10:18:15 +0200 (CEST) From: Julia Lawall X-X-Sender: jll@hadrien To: Markus Elfring cc: linux-nfs@vger.kernel.org, Anna Schumaker , Trond Myklebust , LKML , kernel-janitors@vger.kernel.org Subject: Re: [PATCH] NFS: Less function calls in show_pnfs() In-Reply-To: Message-ID: References: User-Agent: Alpine 2.20 (DEB 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Tue, 2 Jul 2019, Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 2 Jul 2019 16:30:53 +0200 > > Reduce function calls for data output into a sequence. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > fs/nfs/super.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/fs/nfs/super.c b/fs/nfs/super.c > index f88ddac2dcdf..c301cd585b3b 100644 > --- a/fs/nfs/super.c > +++ b/fs/nfs/super.c > @@ -749,11 +749,10 @@ static void show_sessions(struct seq_file *m, struct nfs_server *server) {} > #ifdef CONFIG_NFS_V4_1 > static void show_pnfs(struct seq_file *m, struct nfs_server *server) > { > - seq_printf(m, ",pnfs="); > - if (server->pnfs_curr_ld) > - seq_printf(m, "%s", server->pnfs_curr_ld->name); > - else > - seq_printf(m, "not configured"); > + seq_printf(m, ",pnfs=%s", > + server->pnfs_curr_ld > + ? server->pnfs_curr_ld->name > + : "not configured"); Unreadable. julia > } > > static void show_implementation_id(struct seq_file *m, struct nfs_server *nfss) > -- > 2.22.0 > >