From: Benjamin Coddington <bcodding@redhat.com>
To: Jeff Layton <jlayton@poochiereds.net>
Cc: bfields@fieldses.org, Anna Schumaker <Anna.Schumaker@netapp.com>,
Andrew W Elble <aweits@rit.edu>,
linux-nfs@vger.kernel.org
Subject: Re: [PATCH 0/2] nfsd: fix unhashing races in nfsv4 stateid handling
Date: Fri, 18 Sep 2015 15:07:09 -0400 (EDT) [thread overview]
Message-ID: <alpine.OSX.2.19.9992.1509181506080.4198@planck.local> (raw)
In-Reply-To: <alpine.OSX.2.19.9992.1509181504300.4198@planck.local>
On Fri, 18 Sep 2015, Benjamin Coddington wrote:
> ACK to these two. Sorry for the delay..
>
> Ben
Whoops! Wrong posting, please disregard. Sorry about the noise.
Not that this work is un-ackable. Excellent work, this. Thanks for fixing
this Jeff.
Ben
>
> On Sat, 22 Aug 2015, Jeff Layton wrote:
>
> > I hadn't heard from Andrew in a while so I'm not 100% clear on whether
> > his patches had fixed the race that he had spotted in the NFSv4
> > unhashing code.
> >
> > Still, once he had done the analysis, the problem was clear. I think
> > this patchset should fix the problem in a relatively clean way. I've
> > run some tests against this and it seems to not have broken anything,
> > but I haven't been able to reproduce the actual race so I can't
> > verify that this fixes it.
> >
> > Andrew, Anna, if you are able to do so could you test these patches
> > and let us know whether this fixes those races?
> >
> > Jeff Layton (2):
> > nfsd: ensure that the ol stateid hash reference is only put once
> > nfsd: ensure that delegation stateid hash references are only put once
> >
> > fs/nfsd/nfs4state.c | 76 ++++++++++++++++++++++++++++++++++-------------------
> > 1 file changed, 49 insertions(+), 27 deletions(-)
> >
> > --
> > 2.4.3
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> >
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2015-09-18 19:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-22 14:52 [PATCH 0/2] nfsd: fix unhashing races in nfsv4 stateid handling Jeff Layton
2015-08-22 14:52 ` [PATCH 1/2] nfsd: ensure that the ol stateid hash reference is only put once Jeff Layton
2015-08-22 14:52 ` [PATCH 2/2] nfsd: ensure that delegation stateid hash references are " Jeff Layton
2015-09-18 19:05 ` [PATCH 0/2] nfsd: fix unhashing races in nfsv4 stateid handling Benjamin Coddington
2015-09-18 19:07 ` Benjamin Coddington [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.OSX.2.19.9992.1509181506080.4198@planck.local \
--to=bcodding@redhat.com \
--cc=Anna.Schumaker@netapp.com \
--cc=aweits@rit.edu \
--cc=bfields@fieldses.org \
--cc=jlayton@poochiereds.net \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).