From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=95.215.58.24 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1795180283; b=kDXpqlUeFFvhR0ZUfWuwYnjeOb5KPyO/+RENfRsyoGsJ5d/y0450KkUrV5t7A2IlUY7z ecydXpWdsulEqy0tlg910414SanXwpn1LsKIsLAOhfDxu2Mv3KWzwIOiWs1OTB8DMDngU yQE5P0cIRQq22asBwemnaATPdfMo2E/PMNeZMv9augpcmYmjxQQ5Wm4uIq2dR0fDCjRdv Ob2m4QpeflaR1abqKl/QN7+c5FrLEznT4/1KnQrxMLbCxrj3QgBxNvHEyU5b2T3Wpzx1d 3q5aa3+A6yceT6np2IMwm7268TwfLHc4XYn/VHqx/EaO4V1H6EHM/wzZF0tBoJubs1A== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1795180283; h=DMARC-Filter:X-Envelope-To:DKIM-Signature:X-Envelope-To:Received: X-Mizu-Trace-ID:X-Migadu-Flow:Date:From:To:Cc:Subject:Message-ID: References:MIME-Version:Content-Type:Content-Disposition:In-Reply-To; bh=11EUqqsBHqKJhSEKaLjedxJRvUSCpiSlKRotGWVYopQ=; b=MJrYdCEZqQhWrVPzSElQMefsx6l2hzBnp6vGQwKKd4ez14l9Z0juTRSvYArEMRuN48uI oKtFrE3uRMSR3nMRkIJXwzjwQrm583gwO3y1WA1lGZpJw5e9miVDILy2UT/W3KacA168d aE8ZZe1phaDinvEOi54rNAynteGd4IIu8SP2ZoCLYcAla7HOvApXKn3InOxoZCmW5q640 yOlUM6nhNyYl0tcGW8weIPv9x57bj7vzrIyrRUwvFlBHqNZoFaj15HQ19wTgxrdm7GUq5 wdvKPhKv2+aCy55a2iGOIhMg9nFwH8UL3Hv6x775k5grWSYPU3D4Y8ZepkwsxyFxfVw== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=pcpMXMRk; arc=none smtp.remote-ip=95.215.58.24 Received: from mta1.migadu.com (out-24.mta1.migadu.com [95.215.58.24]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D05B8606A337 for ; Fri, 20 Nov 2026 13:11:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org D05B8606A337 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key, unprotected) header.d=linux.dev header.i=@linux.dev header.a=rsa-sha256 header.s=key1 header.b=pcpMXMRk X-Envelope-To: linux-nfs@vger.kernel.org DKIM-Signature: a=rsa-sha256; bh=AFN9OOtQlK1HJO8cWelVMtGeAQ6PKLi87EwwnhaP1iY=; c=simple/simple; d=linux.dev; h=from:to:subject:date:message-id:mime-version:content-type; s=key1; t=1795180281; v=1; x=1795785081; b=pcpMXMRkQ4Ns6fd064vPWWatVGroU9IVtkGO3ROe58Y6pOfgmdrRaA8URbSyfTUF5AbEgZhD i68/L46VO8eq6YVzH9zTsvTRNPM0a79tLxALqyXzHBnW3aN7CqxWw7P6596t4l+BKqmEoxYpK8c D1wn0Zhz0yPrczpYDf0gH1hM= X-Envelope-To: linux-nfs@vger.kernel.org Received: by smtp.migadu.com with ESMTPS id 1d043ee31403846b; Fri, 20 Nov 2026 13:11:20 +0000 X-Mizu-Trace-ID: 1d043ee31403846b X-Migadu-Flow: FLOW_OUT Date: Fri, 20 Nov 2026 14:11:11 +0100 From: "Pankaj Raghav (Samsung)" To: Jan Kara Cc: Christian Brauner , linux-fsdevel@vger.kernel.org, Andreas Gruenbacher , gfs2@lists.linux.dev, Mike Marshall , Martin Brandenburg , devel@lists.orangefs.org, Dave Kleikamp , jfs-discussion@lists.sourceforge.net, Carlos Maiolino , linux-xfs@vger.kernel.org, David Howells , Marc Dionne , linux-afs@lists.infradead.org, Miklos Szeredi , fuse-devel@lists.linux.dev, linux-block@vger.kernel.org, Chuck Lever , Jeff Layton , linux-nfs@vger.kernel.org, Eric Biggers , Jaegeuk Kim , linux-fscrypt@vger.kernel.org, Carlos Maiolino Subject: Re: [PATCH 02/13] xfs: Drop pointless I_DIRTY_PAGES check in xfs_can_free_cowblocks() Message-ID: References: <20261116171044.6938-1-jack@suse.cz> <20261118145941.1063127-15-jack@suse.cz> X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20261118145941.1063127-15-jack@suse.cz> On Wed, Nov 18, 2026 at 03:59:36PM +0100, Jan Kara wrote: > PAGECACHE_TAG_DIRTY is the authoritative source of information about any > folio being dirty in the mapping. I_DIRTY_PAGES is just an approximation > used by writeback code that can get stale under certain situations. So > just rely on the authoritative check. > > Reviewed-by: Carlos Maiolino > Signed-off-by: Jan Kara Looks good, Reviewed-by: Pankaj Raghav (Samsung) > --- > fs/xfs/xfs_reflink.h | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/fs/xfs/xfs_reflink.h b/fs/xfs/xfs_reflink.h > index 683c1841e640..1310cc9fe829 100644 > --- a/fs/xfs/xfs_reflink.h > +++ b/fs/xfs/xfs_reflink.h > @@ -17,8 +17,7 @@ xfs_can_free_cowblocks(struct xfs_inode *ip) > { > struct inode *inode = VFS_I(ip); > > - if ((inode_state_read_once(inode) & I_DIRTY_PAGES) || > - mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY) || > + if (mapping_tagged(inode->i_mapping, PAGECACHE_TAG_DIRTY) || > mapping_tagged(inode->i_mapping, PAGECACHE_TAG_WRITEBACK) || > atomic_read(&inode->i_dio_count)) > return false; > -- > 2.53.0 >