From: Trond Myklebust <trondmy@hammerspace.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 0/4] A collection of NFS client tracepoint patches
Date: Mon, 4 Oct 2021 15:46:07 +0000 [thread overview]
Message-ID: <b47160ac25bc7781855517d61a586efd78fedd8e.camel@hammerspace.com> (raw)
In-Reply-To: <163335628674.1225.6965764965914263799.stgit@morisot.1015granger.net>
On Mon, 2021-10-04 at 10:09 -0400, Chuck Lever wrote:
> Hi-
>
> This series proposes a small handful of tracepoint-related changes.
>
> The first patch is clean-up.
>
> The second and third patches are part of the ongoing effort to
> replace dprintk with tracepoints.
>
> The last patch adds some tracepoints I found useful while diagnosing
> the recent NFSv3 fsx failures.
>
> ---
>
> Chuck Lever (4):
> NFS: Remove unnecessary TRACE_DEFINE_ENUM()s
> SUNRPC: Tracepoints should store tk_pid and cl_clid as a signed
> int
> SUNRPC: Per-rpc_clnt task PIDs
> NFS: Instrument i_size_write()
I'm fine with applying patches 1, 3 and 4 for now, but I have strong
reservations about patch 2.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
prev parent reply other threads:[~2021-10-04 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 14:09 [PATCH 0/4] A collection of NFS client tracepoint patches Chuck Lever
2021-10-04 14:09 ` [PATCH 1/4] NFS: Remove unnecessary TRACE_DEFINE_ENUM()s Chuck Lever
2021-10-04 14:10 ` [PATCH 2/4] SUNRPC: Tracepoints should store tk_pid and cl_clid as a signed int Chuck Lever
2021-10-04 15:41 ` Trond Myklebust
2021-10-04 15:59 ` Chuck Lever III
2021-10-04 14:10 ` [PATCH 3/4] SUNRPC: Per-rpc_clnt task PIDs Chuck Lever
2021-10-04 14:10 ` [PATCH 4/4] NFS: Instrument i_size_write() Chuck Lever
2021-10-04 15:46 ` Trond Myklebust [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b47160ac25bc7781855517d61a586efd78fedd8e.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).