From: Jeff Layton <jlayton@kernel.org>
To: NeilBrown <neilb@suse.de>, Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org, Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/2] nfsd: proper fix for NULL deref in svc_pool_stats_start()
Date: Tue, 25 Jun 2024 06:16:28 -0400 [thread overview]
Message-ID: <b498bf3ad654fcd44c9ade5b7fac98f6c68acc42.camel@kernel.org> (raw)
In-Reply-To: <20240624230734.17084-1-neilb@suse.de>
On Tue, 2024-06-25 at 09:04 +1000, NeilBrown wrote:
> A recent patch attempted to fix a NULL pointer deref but introduced a
> different NULL pointer deref and a possible unbalance unlock.
>
> This series fixes the bug correctly and reverts the faulty fix.
>
> (Sorry for not reviewing this patch earlier)
>
> NeilBrown
>
> [PATCH 1/2] nfsd: initialise nfsd_info.mutex early.
> [PATCH 2/2] Revert "nfsd: fix oops when reading pool_stats before
Yes, this looks like a superior fix. Thanks, Neil!
Reviewed-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-06-25 10:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 23:04 [PATCH 0/2] nfsd: proper fix for NULL deref in svc_pool_stats_start() NeilBrown
2024-06-24 23:04 ` [PATCH 1/2] nfsd: initialise nfsd_info.mutex early NeilBrown
2024-06-24 23:04 ` [PATCH 2/2] Revert "nfsd: fix oops when reading pool_stats before server is started" NeilBrown
2024-06-25 10:16 ` Jeff Layton [this message]
2024-06-25 14:22 ` [PATCH 0/2] nfsd: proper fix for NULL deref in svc_pool_stats_start() Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b498bf3ad654fcd44c9ade5b7fac98f6c68acc42.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox