linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@redhat.com>
To: "Jianhong.Yin" <yin-jianhong@163.com>, linux-nfs@vger.kernel.org
Cc: Jianhong Yin <jiyin@redhat.com>
Subject: Re: [PATCH] exportfs: fix export point checking
Date: Mon, 18 Jul 2016 13:33:03 -0400	[thread overview]
Message-ID: <b5964dc7-c8af-8ffc-dfd4-c1355d9d9292@RedHat.com> (raw)
In-Reply-To: <1468041333-30255-1-git-send-email-yin-jianhong@163.com>



On 07/09/2016 01:15 AM, Jianhong.Yin wrote:
> NFS does not support file and symbolic export, if the export point
> is regular file should give warning to user.
> 
> Signed-off-by: Jianhong Yin <jiyin@redhat.com>
> ---
>  utils/exportfs/exportfs.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
Committed... 

steved.
> 
> diff --git a/utils/exportfs/exportfs.c b/utils/exportfs/exportfs.c
> index 5db348b..a00b5ea 100644
> --- a/utils/exportfs/exportfs.c
> +++ b/utils/exportfs/exportfs.c
> @@ -585,8 +585,8 @@ validate_export(nfs_export *exp)
>  		xlog(L_ERROR, "Failed to stat %s: %m", path);
>  		return;
>  	}
> -	if (!S_ISDIR(stb.st_mode) && !S_ISREG(stb.st_mode)) {
> -		xlog(L_ERROR, "%s is neither a directory nor a file. "
> +	if (!S_ISDIR(stb.st_mode)) {
> +		xlog(L_ERROR, "%s is not a directory. "
>  			"Remote access will fail", path);
>  		return;
>  	}
> 

  reply	other threads:[~2016-07-18 17:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-09  5:15 [PATCH] exportfs: fix export point checking Jianhong.Yin
2016-07-18 17:33 ` Steve Dickson [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-07-14  5:35 Jianhong.Yin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5964dc7-c8af-8ffc-dfd4-c1355d9d9292@RedHat.com \
    --to=steved@redhat.com \
    --cc=jiyin@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=yin-jianhong@163.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).