public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>,
	Thorsten Leemhuis <linux@leemhuis.info>,
	 NeilBrown <neilb@ownmail.net>,
	Olga Kornievskaia <okorniev@redhat.com>,
	Dai Ngo <dai.ngo@oracle.com>,  Tom Talpey <tom@talpey.com>
Cc: linux-nfs@vger.kernel.org, Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH] NFSD: Put cache get-reqs dump attrs under reply
Date: Thu, 23 Apr 2026 13:50:34 -0400	[thread overview]
Message-ID: <b5d6ce7d4d34ee2b30556e0e671abc10ebf4535b.camel@kernel.org> (raw)
In-Reply-To: <13219731-89be-4c49-8842-69935c21eb2f@kernel.org>

On Thu, 2026-04-23 at 13:26 -0400, Chuck Lever wrote:
> On 4/23/26 10:24 AM, Thorsten Leemhuis wrote:
> > On 4/23/26 19:17, Chuck Lever wrote:
> > > From: Chuck Lever <chuck.lever@oracle.com>
> > > 
> > > The new get-reqs dump operations added to sunrpc_cache.yaml and
> > > nfsd.yaml place the "requests" nested attribute under dump.request.
> > > A netlink dump carries an empty request; its payload travels back
> > > in the reply. Because the spec names no reply attributes, the YNL
> > > C code generator synthesizes a forward reference to a
> > > <op>_rsp struct that is never defined, breaking any consumer of
> > > these specs.
> > > 
> > > This first surfaced when Thorsten Leemhuis built tools/net/ynl
> > > against -next:
> > 
> > Thx for the quick fix, this makes things work. In case anybody cares:
> > 
> > Tested-by: Thorsten Leemhuis <linux@leemhuis.info>
> 
> Thanks! Applied to nfsd-next.
> 
> 

Many thanks! I was just sitting down to look at Thorsten's mail.
-- 
Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2026-04-23 17:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-23 17:17 [PATCH] NFSD: Put cache get-reqs dump attrs under reply Chuck Lever
2026-04-23 17:24 ` Thorsten Leemhuis
2026-04-23 17:26   ` Chuck Lever
2026-04-23 17:50     ` Jeff Layton [this message]
2026-04-23 17:57       ` Chuck Lever
  -- strict thread matches above, loose matches on Subject: below --
2026-04-23 18:15 [PATCH 0/4] cleanup block-style layouts exports v3 Chuck Lever
2026-04-23 18:15 ` [PATCH] NFSD: Put cache get-reqs dump attrs under reply Chuck Lever
2026-04-23 18:16   ` Chuck Lever
2026-04-23 18:18   ` Jeff Layton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b5d6ce7d4d34ee2b30556e0e671abc10ebf4535b.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=dai.ngo@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux@leemhuis.info \
    --cc=neilb@ownmail.net \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox