From: Trond Myklebust <trondmy@hammerspace.com>
To: "neilb@suse.de" <neilb@suse.de>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"aglo@umich.edu" <aglo@umich.edu>,
"Anna.Schumaker@netapp.com" <Anna.Schumaker@netapp.com>,
"schumaker.anna@gmail.com" <schumaker.anna@gmail.com>
Subject: Re: [PATCH 2/2] NFSv4: Fix a state manager thread deadlock regression
Date: Mon, 25 Sep 2023 23:20:58 +0000 [thread overview]
Message-ID: <b7aca856b71436fadb95f00abeb848d4185af009.camel@hammerspace.com> (raw)
In-Reply-To: <169568304501.19404.1610884104930799751@noble.neil.brown.name>
On Tue, 2023-09-26 at 09:04 +1000, NeilBrown wrote:
>
> Are writes blocked while the delegation returns proceeds? If not,
> would
> it be reasonable to start a separate kthread on-demand when a return
> is
> requested?
>
That's what we've done historically.
We initially made it be the same thread as the standard recovery thread
because we do want to serialise recovery and delegation return. However
the recovery thread has the ability to block all other RPC to the
server in question, so that requirement that we serialise does not
depend on the two threads being the same. In practice, therefore, we
usually ended up with multiple separate threads when reboot recovery
was required during a delegation return, or if a single sweep of the
delegations took too long.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2023-09-25 23:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 23:05 [PATCH 1/2] NFSv4: Fix a nfs4_state_manager() race trondmy
2023-09-17 23:05 ` [PATCH 2/2] NFSv4: Fix a state manager thread deadlock regression trondmy
2023-09-18 1:25 ` NeilBrown
2023-09-18 2:27 ` Trond Myklebust
2023-09-20 19:38 ` Anna Schumaker
2023-09-21 0:15 ` Trond Myklebust
2023-09-22 17:22 ` Olga Kornievskaia
2023-09-22 19:05 ` Trond Myklebust
2023-09-22 21:00 ` Olga Kornievskaia
2023-09-22 21:06 ` Trond Myklebust
2023-09-24 17:08 ` Trond Myklebust
2023-09-26 14:55 ` Anna Schumaker
2023-09-26 14:31 ` Olga Kornievskaia
2023-09-25 22:28 ` NeilBrown
2023-09-25 22:44 ` Trond Myklebust
2023-09-25 23:04 ` NeilBrown
2023-09-25 23:20 ` Trond Myklebust [this message]
2023-09-18 1:17 ` [PATCH 1/2] NFSv4: Fix a nfs4_state_manager() race NeilBrown
2023-09-18 2:20 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b7aca856b71436fadb95f00abeb848d4185af009.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=Anna.Schumaker@netapp.com \
--cc=aglo@umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=schumaker.anna@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).