Re: [PATCH v1 1/5] NFSD: Remove definition for trace_nfsd_file_unhash_and_queue

Jeff Layton
2025-06-13T20:59:29Z

On Fri, 2025-06-13 at 16:07 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> trace_nfsd_file_unhash_and_queue() was removed by commit ac3a2585f01
> ("nfsd: rework refcounting in filecache").
>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/trace.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/nfsd/trace.h b/fs/nfsd/trace.h
> index b244c6b3e905..93875c7ba358 100644
> --- a/fs/nfsd/trace.h
> +++ b/fs/nfsd/trace.h
> @@ -1108,7 +1108,6 @@ DEFINE_NFSD_FILE_EVENT(nfsd_file_free);
> DEFINE_NFSD_FILE_EVENT(nfsd_file_unhash);
> DEFINE_NFSD_FILE_EVENT(nfsd_file_put);
> DEFINE_NFSD_FILE_EVENT(nfsd_file_closing);
> -DEFINE_NFSD_FILE_EVENT(nfsd_file_unhash_and_queue);
>
> TRACE_EVENT(nfsd_file_alloc,
> TP_PROTO(

You can add this to all 5:

Reviewed-by: Jeff Layton <jlayton@kernel.org>