* [PATCH 21/21] sunrpc: exit_net cleanup check added
@ 2017-11-05 10:02 Vasily Averin
2017-11-08 1:22 ` Stephen Hemminger
0 siblings, 1 reply; 3+ messages in thread
From: Vasily Averin @ 2017-11-05 10:02 UTC (permalink / raw)
To: netdev
Cc: linux-nfs, Anna Schumaker, Trond Myklebust, Jeff Layton,
J. Bruce Fields
Be sure that all_clients list initialized in net_init hook was return
to initial state.
Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
---
net/sunrpc/sunrpc_syms.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
index c73de18..0c5a90f 100644
--- a/net/sunrpc/sunrpc_syms.c
+++ b/net/sunrpc/sunrpc_syms.c
@@ -65,10 +65,14 @@ static __net_init int sunrpc_init_net(struct net *net)
static __net_exit void sunrpc_exit_net(struct net *net)
{
+ struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
+
rpc_pipefs_exit_net(net);
unix_gid_cache_destroy(net);
ip_map_cache_destroy(net);
rpc_proc_exit(net);
+ WARN(!list_empty(&sn->all_clients),
+ "net %p exit: sunrpc all_clients list is not empty\n", net);
}
static struct pernet_operations sunrpc_net_ops = {
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 21/21] sunrpc: exit_net cleanup check added
2017-11-05 10:02 [PATCH 21/21] sunrpc: exit_net cleanup check added Vasily Averin
@ 2017-11-08 1:22 ` Stephen Hemminger
2017-11-08 4:50 ` Vasily Averin
0 siblings, 1 reply; 3+ messages in thread
From: Stephen Hemminger @ 2017-11-08 1:22 UTC (permalink / raw)
To: Vasily Averin
Cc: netdev, linux-nfs, Anna Schumaker, Trond Myklebust, Jeff Layton,
J. Bruce Fields
On Sun, 5 Nov 2017 13:02:44 +0300
Vasily Averin <vvs@virtuozzo.com> wrote:
> Be sure that all_clients list initialized in net_init hook was return
> to initial state.
>
> Signed-off-by: Vasily Averin <vvs@virtuozzo.com>
> ---
> net/sunrpc/sunrpc_syms.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/net/sunrpc/sunrpc_syms.c b/net/sunrpc/sunrpc_syms.c
> index c73de18..0c5a90f 100644
> --- a/net/sunrpc/sunrpc_syms.c
> +++ b/net/sunrpc/sunrpc_syms.c
> @@ -65,10 +65,14 @@ static __net_init int sunrpc_init_net(struct net *net)
>
> static __net_exit void sunrpc_exit_net(struct net *net)
> {
> + struct sunrpc_net *sn = net_generic(net, sunrpc_net_id);
> +
> rpc_pipefs_exit_net(net);
> unix_gid_cache_destroy(net);
> ip_map_cache_destroy(net);
> rpc_proc_exit(net);
> + WARN(!list_empty(&sn->all_clients),
> + "net %p exit: sunrpc all_clients list is not empty\n", net);
> }
Don't print a kernel pointer, this is a security leak.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 21/21] sunrpc: exit_net cleanup check added
2017-11-08 1:22 ` Stephen Hemminger
@ 2017-11-08 4:50 ` Vasily Averin
0 siblings, 0 replies; 3+ messages in thread
From: Vasily Averin @ 2017-11-08 4:50 UTC (permalink / raw)
To: Stephen Hemminger
Cc: netdev, linux-nfs, Anna Schumaker, Trond Myklebust, Jeff Layton,
J. Bruce Fields
On 2017-11-08 04:22, Stephen Hemminger wrote:
> On Sun, 5 Nov 2017 13:02:44 +0300
> Vasily Averin <vvs@virtuozzo.com> wrote:
>> + WARN(!list_empty(&sn->all_clients),
>> + "net %p exit: sunrpc all_clients list is not empty\n", net);
>
> Don't print a kernel pointer, this is a security leak.
Yes, you're right, I've submitted fixed patch in v3 already,
but seems will prepare v4 with simple WARN_ON_ONCE(!list_empty())
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-11-08 4:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-05 10:02 [PATCH 21/21] sunrpc: exit_net cleanup check added Vasily Averin
2017-11-08 1:22 ` Stephen Hemminger
2017-11-08 4:50 ` Vasily Averin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).