Re: [PATCH 0/1] Enable inter server to server copies on a export

Chuck Lever III
2021-11-01T21:23:23Z

> On Nov 1, 2021, at 2:39 PM, Bruce Fields <bfields@fieldses.org> wrote:
>
> On Mon, Nov 01, 2021 at 04:55:45PM +0000, Chuck Lever III wrote:
>>
>>> On Nov 1, 2021, at 11:40 AM, J. Bruce Fields <bfields@fieldses.org> wrote:
>>>
>>> On Mon, Nov 01, 2021 at 11:30:48AM -0400, Steve Dickson wrote:
>>>> Hey!
>>>>
>>>> On 10/29/21 15:14, J. Bruce Fields wrote:
>>>>> On Fri, Oct 29, 2021 at 01:30:36PM -0400, Steve Dickson wrote:
>>>>>> On 10/29/21 12:40, J. Bruce Fields wrote:
>>>>>>> Let's just stick with that for now, and leave it off by default until
>>>>>>> we're sure it's mature enough. Let's not introduce new configuration to
>>>>>>> work around problems that we haven't really analyzed yet.
>>>>>> How is this going to find problems? At least with the export option
>>>>>> it is documented
>>>>>
>>>>> That sounds fixable. We need documentation of module parameters anyway.
>>>> Yeah I just took I don't see any documentation of module
>>>> parameters anywhere for any of the modules. But by documentation
>>>> I meant having the feature in the exports(5) manpage.
>>>
>>> I think I'd probably create a new page for sysctls (this isn't the only
>>> one needing documentation), and make sure it's listed in the "SEE ALSO"
>>> section of the other man pages.
>>
>> Aren't sysctls documented under Documentation/ ?
>
> Sorry, I meant "module parameter". Anyway, yes, looks like both are
> listed in Documentation/admin-guide/kernel-parameters.txt.
>
> Might be nice if these were in a man page too somewhere, but maybe
> that's not the most important thing these days.
>
> --b.

This looks like a step forward to me.

> diff --git a/Documentation/admin-guide/kernel-parameters.txt b/Documentation/admin-guide/kernel-parameters.txt
> index 91ba391f9b32..14bc3f0b0149 100644
> --- a/Documentation/admin-guide/kernel-parameters.txt
> +++ b/Documentation/admin-guide/kernel-parameters.txt
> @@ -3243,6 +3243,19 @@
> driver. A non-zero value sets the minimum interval
> in seconds between layoutstats transmissions.
>
> + nfsd.inter_copy_offload_enable =
> + [NFSv4.2] When set to 1, the server will support
> + server-to-server copies for which this server is
> + the destination of the copy.
> +
> + nfsd.nfsd4_ssc_umount_timeout =
> + [NFSv4.2] When used as the destination of a
> + server-to-server copy, knfsd temporarily mounts
> + the source server. It caches the mount in case
> + it will be needed again, and discards it if not
> + used for the number of milliseconds specified by
> + this parameter.
> +
> nfsd.nfs4_disable_idmapping=
> [NFSv4] When set to the default of '1', the NFSv4
> server will return only numeric uids and gids to
> @@ -3250,6 +3263,7 @@
> and gids from such clients. This is intended to ease
> migration from NFSv2/v3.
>
> +
> nmi_backtrace.backtrace_idle [KNL]
> Dump stacks even of idle CPUs in response to an
> NMI stack-backtrace request.

--
Chuck Lever