From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Cc: Chuck Lever <chuck.lever@oracle.com>
Subject: Re: [PATCH v1 0/7] Clean up XDR encoders for NFSv4 OPEN and LOCK
Date: Fri, 29 Sep 2023 12:26:33 -0400 [thread overview]
Message-ID: <c6ed1c23c7d2ff4b7e1422458c28a44e25599fb7.camel@kernel.org> (raw)
In-Reply-To: <169599581942.5622.15965175797823365235.stgit@manet.1015granger.net>
On Fri, 2023-09-29 at 09:58 -0400, Chuck Lever wrote:
> Tidy up the server-side XDR encoders for NFSv4 OPEN and LOCK
> results. Series applies to nfsd-next. See topic branch
> "nfsd4-encoder-overhaul" in this repo:
>
> https://git.kernel.org/pub/scm/linux/kernel/git/cel/linux.git
>
> ---
>
> Chuck Lever (7):
> NFSD: Add nfsd4_encode_lock_owner4()
> NFSD: Refactor nfsd4_encode_lock_denied()
> NFSD: Add nfsd4_encode_open_read_delegation4()
> NFSD: Add nfsd4_encode_open_write_delegation4()
> NFSD: Add nfsd4_encode_open_none_delegation4()
> NFSD: Add nfsd4_encode_open_delegation4()
> NFSD: Clean up nfsd4_encode_open()
>
>
> fs/nfsd/nfs4state.c | 6 +-
> fs/nfsd/nfs4xdr.c | 305 +++++++++++++++++++++++++++-----------------
> fs/nfsd/xdr4.h | 2 +-
> 3 files changed, 189 insertions(+), 124 deletions(-)
>
> --
> Chuck Lever
>
Looks pretty straightforward. I had one minor nit about the struct
packing but the rest looks fine. You can add:
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-09-29 16:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 13:58 [PATCH v1 0/7] Clean up XDR encoders for NFSv4 OPEN and LOCK Chuck Lever
2023-09-29 13:58 ` [PATCH v1 1/7] NFSD: Add nfsd4_encode_lock_owner4() Chuck Lever
2023-09-29 13:58 ` [PATCH v1 2/7] NFSD: Refactor nfsd4_encode_lock_denied() Chuck Lever
2023-09-29 13:59 ` [PATCH v1 3/7] NFSD: Add nfsd4_encode_open_read_delegation4() Chuck Lever
2023-09-29 16:21 ` Jeff Layton
2023-09-29 17:23 ` Chuck Lever
2023-09-29 13:59 ` [PATCH v1 4/7] NFSD: Add nfsd4_encode_open_write_delegation4() Chuck Lever
2023-09-29 13:59 ` [PATCH v1 5/7] NFSD: Add nfsd4_encode_open_none_delegation4() Chuck Lever
2023-09-29 13:59 ` [PATCH v1 6/7] NFSD: Add nfsd4_encode_open_delegation4() Chuck Lever
2023-09-29 13:59 ` [PATCH v1 7/7] NFSD: Clean up nfsd4_encode_open() Chuck Lever
2023-09-29 16:26 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c6ed1c23c7d2ff4b7e1422458c28a44e25599fb7.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).