From: Li Lingfeng <lilingfeng@huaweicloud.com>
To: Jeff Layton <jlayton@kernel.org>,
Li Lingfeng <lilingfeng3@huawei.com>,
trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com,
neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com,
tom@talpey.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai1@huaweicloud.com, houtao1@huawei.com, yi.zhang@huawei.com,
yangerkun@huawei.com
Subject: Re: [PATCH 2/4] nfsd: fix some spelling errors in comments
Date: Sat, 24 Aug 2024 08:54:18 +0800 [thread overview]
Message-ID: <ca5e64ca-ac6e-3d58-297a-d99c9f57d38e@huaweicloud.com> (raw)
In-Reply-To: <f27ca56a2b7de7ebb97a4170222047da56eb8eb7.camel@kernel.org>
在 2024/8/23 20:07, Jeff Layton 写道:
> On Fri, 2024-08-23 at 15:00 +0800, Li Lingfeng wrote:
>> Fix spelling errors in comments of nfsd4_release_lockowner and
>> nfs4_set_delegation.
>>
>> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
>> ---
>> fs/nfsd/nfs4state.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
>> index a20c2c9d7d45..66a0c76850f3 100644
>> --- a/fs/nfsd/nfs4state.c
>> +++ b/fs/nfsd/nfs4state.c
>> @@ -5856,7 +5856,7 @@ nfs4_set_delegation(struct nfsd4_open *open, struct nfs4_ol_stateid *stp,
>>
>> /*
>> * Now that the deleg is set, check again to ensure that nothing
>> - * raced in and changed the mode while we weren't lookng.
>> + * raced in and changed the mode while we weren't looking.
>> */
>> status = nfsd4_verify_setuid_write(open, fp->fi_deleg_file);
>> if (status)
>> @@ -8335,7 +8335,7 @@ check_for_locks(struct nfs4_file *fp, struct nfs4_lockowner *lowner)
>> * @cstate: NFSv4 COMPOUND state
>> * @u: RELEASE_LOCKOWNER arguments
>> *
>> - * Check if theree are any locks still held and if not - free the lockowner
>> + * Check if there are any locks still held and if not - free the lockowner
> This is probably better grammatically:
>
> Check if there are any locks still held and if not, free the lockowner
Thanks for your advice, it does look better.
>> * and any lock state that is owned.
>> *
>> * Return values:
next prev parent reply other threads:[~2024-08-24 0:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 7:00 [PATCH 0/4] nfsd: fix some comments and code cleanup Li Lingfeng
2024-08-23 7:00 ` [PATCH 1/4] nfsd: fix the comment of nfs_get_root Li Lingfeng
2024-08-23 12:06 ` Jeff Layton
2024-08-23 7:00 ` [PATCH 2/4] nfsd: fix some spelling errors in comments Li Lingfeng
2024-08-23 12:07 ` Jeff Layton
2024-08-24 0:54 ` Li Lingfeng [this message]
2024-08-23 7:00 ` [PATCH 3/4] nfsd: remove the redundant blank line Li Lingfeng
2024-08-23 12:08 ` Jeff Layton
2024-08-24 0:44 ` Li Lingfeng
2024-08-23 7:00 ` [PATCH 4/4] nfsd: remove unused parameter of nfsd_file_mark_find_or_create Li Lingfeng
2024-08-23 12:09 ` Jeff Layton
2024-08-23 16:39 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ca5e64ca-ac6e-3d58-297a-d99c9f57d38e@huaweicloud.com \
--to=lilingfeng@huaweicloud.com \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=houtao1@huawei.com \
--cc=jlayton@kernel.org \
--cc=kolga@netapp.com \
--cc=lilingfeng3@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).