public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Chuck Lever <chuck.lever@oracle.com>
To: Trond Myklebust <trondmy@kernel.org>,
	Christoph Hellwig <hch@infradead.org>,
	Mike Snitzer <snitzer@kernel.org>
Cc: Jeff Layton <jlayton@kernel.org>,
	Anna Schumaker <anna.schumaker@oracle.com>,
	linux-nfs@vger.kernel.org
Subject: Re: [RFC PATCH v2 00/11] NFS/NFSD: nfs4_acl passthru for NFSv4 reexport
Date: Tue, 10 Mar 2026 10:59:29 -0400	[thread overview]
Message-ID: <caf43aae-e08a-423c-bc32-04acac9d20a4@oracle.com> (raw)
In-Reply-To: <1c630798e0c931310f86f636abe84a72b86f7aae.camel@kernel.org>

On 3/10/26 10:53 AM, Trond Myklebust wrote:
> On Tue, 2026-03-10 at 06:26 -0700, Christoph Hellwig wrote:
>> NAK on this whole thing.  Linux does not support NFSv4 ACLs for
>> pretty
>> good reasons.  If you want to add it you'd have to do it properly
>> (even
>> if that is a bad idea in my opinion).  But adding a weird special
>> case
>> for passthrough is a no-go.  To be honest I really don't understand
>> why
>> your (as in Hammerspae, not you personally) want to abuse the kernel
>> nfsd and nfs client for that.  If you want to pass in the protocol do
>> it in userspace without burdening the kernel with it.
>>
> 
> Like it or not, Linux knfsd _does_ pretend to support NFSv4 ACLs. It
> does so by using a (lossy!) mapping to try to convert the NFSv4 ACL
> into a POSIX style ACL.
> This is a problem when you're re-exporting NFSv4, as we need to do,
> because at best it mangles your ACL. At worst, it throws random error
> codes back at the client.
> 
> So Hammerspace does need that passthrough ACL in order to have re-
> exports work as expected.
> 
> If the upstream community is unwilling to take patches to address the
> issue, then we're quite happy to maintain the code separately. It will
> still be available to those who need it through our github site.

I recognize the need to avoid ACE mapping when re-exporting NFSv4.
This is an issue specifically for NFSD (which remaps NFSv4 ACLs to
POSIX ACLS) and NFSv4 re-export.

I will accept a clean implementation of that for merge, and I've
already pointed out where the prototype implementation can be
improved.


-- 
Chuck Lever

      parent reply	other threads:[~2026-03-10 14:59 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-24 19:24 [RFC PATCH v2 00/11] NFS/NFSD: nfs4_acl passthru for NFSv4 reexport Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 01/11] exportfs: add ability to advertise NFSv4 ACL passthru support Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 02/11] NFSD: factor out nfsd_supports_nfs4_acl() to nfsd/acl.h Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 03/11] NFS/NFSD: data structure enablement for nfs4_acl passthru support Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 04/11] NFSD: prepare to support SETACL nfs4_acl passthru Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 05/11] NFSD: add NFS4 reexport support for " Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 06/11] NFSD: add NFS4 reexport support for GETACL " Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 07/11] NFSD: add NFS4ACL_DACL and NFS4ACL_SACL passthru support Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 08/11] NFSD: avoid extra nfs4_acl passthru work unless needed Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 09/11] NFSv4: add reexport support for SETACL nfs4_acl passthru Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 10/11] NFSv4: add reexport support for GETACL " Mike Snitzer
2026-02-24 19:24 ` [RFC PATCH v2 11/11] NFSv4: set EXPORT_OP_NFSV4_ACL_PASSTHRU flag Mike Snitzer
2026-02-24 21:58 ` [RFC PATCH v2 00/11] NFS/NFSD: nfs4_acl passthru for NFSv4 reexport Chuck Lever
2026-02-25 16:53   ` Mike Snitzer
2026-02-25 18:21     ` Chuck Lever
2026-03-10 13:26 ` Christoph Hellwig
2026-03-10 14:53   ` Trond Myklebust
2026-03-10 14:58     ` Christoph Hellwig
2026-03-10 16:41       ` Chuck Lever
2026-03-10 14:59     ` Chuck Lever [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=caf43aae-e08a-423c-bc32-04acac9d20a4@oracle.com \
    --to=chuck.lever@oracle.com \
    --cc=anna.schumaker@oracle.com \
    --cc=hch@infradead.org \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=snitzer@kernel.org \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox