Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] rpc-pipefs-generator: allocate enough space for pipefs-directory buffer
Date: Fri, 22 Jul 2022 11:02:01 -0400	[thread overview]
Message-ID: <cccb8de2-1f10-335b-7363-e7f3c1108965@redhat.com> (raw)
In-Reply-To: <20220721191812.60294-1-steved@redhat.com>



On 7/21/22 3:18 PM, Steve Dickson wrote:
> Commit 7f8463fe fixed a warning but introduce
> a regression by not allocating enough space
> for the pipefs-directory buffer when it is
> not the default.
> 
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2106896
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed....

steved.

> ---
>   systemd/rpc-pipefs-generator.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/systemd/rpc-pipefs-generator.c b/systemd/rpc-pipefs-generator.c
> index 7b2bb4f7..3aaeaeaf 100644
> --- a/systemd/rpc-pipefs-generator.c
> +++ b/systemd/rpc-pipefs-generator.c
> @@ -28,7 +28,7 @@ static int generate_mount_unit(const char *pipefs_path, const char *pipefs_unit,
>   {
>   	char	*path;
>   	FILE	*f;
> -	size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit));
> +	size_t size = (strlen(dirname) + 1 + strlen(pipefs_unit) + 1);
>   
>   	path = malloc(size);
>   	if (!path)


      reply	other threads:[~2022-07-22 15:02 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-21 19:18 [PATCH] rpc-pipefs-generator: allocate enough space for pipefs-directory buffer Steve Dickson
2022-07-22 15:02 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cccb8de2-1f10-335b-7363-e7f3c1108965@redhat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox