From: Trond Myklebust <trondmy@hammerspace.com>
To: "anna.schumaker@netapp.com" <anna.schumaker@netapp.com>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH 2/4] SUNRPC: Tracepoints should store tk_pid and cl_clid as a signed int
Date: Mon, 4 Oct 2021 15:41:04 +0000 [thread overview]
Message-ID: <ce1a2ef5757fc96c21f2e6402021ca646dfbfa80.camel@hammerspace.com> (raw)
In-Reply-To: <163335660381.1225.8730120749232774829.stgit@morisot.1015granger.net>
On Mon, 2021-10-04 at 10:10 -0400, Chuck Lever wrote:
> ida_simple_get() returns a signed integer. Negative values are error
> returns, but this suggests the range of valid client IDs is zero to
> 2^31 - 1.
>
> tk_pid is currently an unsigned short, so its range is zero to
> 65535.
>
> For certain special cases, RPC-related tracepoints record a -1 as
> the task ID or the client ID. It's ugly for a trace event to display
> 4 billion in these cases.
Ugh... I emphatically do not like the idea of an identifier field that
is signed, whatever its range of validity may be.
If we're going to change anything, then let's rather turn that
identifier into a fixed size hex field in the traces.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2021-10-04 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-04 14:09 [PATCH 0/4] A collection of NFS client tracepoint patches Chuck Lever
2021-10-04 14:09 ` [PATCH 1/4] NFS: Remove unnecessary TRACE_DEFINE_ENUM()s Chuck Lever
2021-10-04 14:10 ` [PATCH 2/4] SUNRPC: Tracepoints should store tk_pid and cl_clid as a signed int Chuck Lever
2021-10-04 15:41 ` Trond Myklebust [this message]
2021-10-04 15:59 ` Chuck Lever III
2021-10-04 14:10 ` [PATCH 3/4] SUNRPC: Per-rpc_clnt task PIDs Chuck Lever
2021-10-04 14:10 ` [PATCH 4/4] NFS: Instrument i_size_write() Chuck Lever
2021-10-04 15:46 ` [PATCH 0/4] A collection of NFS client tracepoint patches Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ce1a2ef5757fc96c21f2e6402021ca646dfbfa80.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=anna.schumaker@netapp.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).