From: Trond Myklebust <trondmy@hammerspace.com>
To: "jlayton@kernel.org" <jlayton@kernel.org>,
"hch@infradead.org" <hch@infradead.org>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
"chuck.lever@oracle.com" <chuck.lever@oracle.com>
Subject: Re: [PATCH 00/19] OPEN optimisations and Attribute delegations
Date: Mon, 17 Jun 2024 01:39:06 +0000 [thread overview]
Message-ID: <cf0f94ff9259d2bd97d51291e420aa368a2e3d6f.camel@hammerspace.com> (raw)
In-Reply-To: <Zm00O4JN7rY2BiiI@infradead.org>
On Fri, 2024-06-14 at 23:27 -0700, Christoph Hellwig wrote:
> On Fri, Jun 14, 2024 at 08:34:32AM -0400, Jeff Layton wrote:
> > This all looks pretty reasonable except for the last two patches.
> > Probably, they should be squashed together since there is no caller
> > of
> > ->return_delegation until the last one. There is also nothing
> > describing the changes there, and I think it could use some
> > explanation
> > (though I think I get what you're doing).
> >
> > Finally, I suppose we need to look at implementing support delstid
> > in
> > knfsd as well. I'll open a new feature request for that the linux-
> > nfs
> > project on github.
>
> I don't think there ever was a formal rule, but having a feature like
> this that affects all of the core nfs code without beeing able to
> test
> it against knfsd seems a bit dangerous indeed.
>
We have been going through the IETF process to ensure there is an
agreed upon protocol for this that can be used to test the client code
and validate its correctness. That spec can also be used by others to
contribute the missing knfsd code.
At some point soon, I do hope that Hammerspace will be in the position
where we're able to contribute both client and server code for these
features; for now, we are unfortunately still resource constrained.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
next prev parent reply other threads:[~2024-06-17 1:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-13 4:11 [PATCH 00/19] OPEN optimisations and Attribute delegations trondmy
2024-06-13 4:11 ` [PATCH 01/19] NFSv4: Clean up open delegation return structure trondmy
2024-06-13 4:11 ` [PATCH 02/19] NFSv4: Refactor nfs4_opendata_check_deleg() trondmy
2024-06-13 4:11 ` [PATCH 03/19] NFSv4: Add new attribute delegation definitions trondmy
2024-06-13 4:11 ` [PATCH 04/19] NFSv4: Plumb in XDR support for the new delegation-only setattr op trondmy
2024-06-13 4:11 ` [PATCH 05/19] NFSv4: Add CB_GETATTR support for delegated attributes trondmy
2024-06-13 4:11 ` [PATCH 06/19] NFSv4: Add a flags argument to the 'have_delegation' callback trondmy
2024-06-13 4:11 ` [PATCH 07/19] NFSv4: Add support for delegated atime and mtime attributes trondmy
2024-06-13 4:11 ` [PATCH 08/19] NFSv4: Add recovery of attribute delegations trondmy
2024-06-13 4:11 ` [PATCH 09/19] NFSv4: Add a capability for delegated attributes trondmy
2024-06-13 4:11 ` [PATCH 10/19] NFSv4: Enable attribute delegations trondmy
2024-06-13 4:11 ` [PATCH 11/19] NFSv4: Delegreturn must set m/atime when they are delegated trondmy
2024-06-13 4:11 ` [PATCH 12/19] NFSv4: Fix up delegated attributes in nfs_setattr trondmy
2024-06-13 4:11 ` [PATCH 13/19] NFSv4: Don't request atime/mtime/size if they are delegated to us trondmy
2024-06-13 4:11 ` [PATCH 14/19] NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute trondmy
2024-06-13 4:11 ` [PATCH 15/19] NFSv4: Detect support for OPEN4_SHARE_ACCESS_WANT_OPEN_XOR_DELEGATION trondmy
2024-06-13 4:11 ` [PATCH 16/19] NFSv4: Add support for OPEN4_RESULT_NO_OPEN_STATEID trondmy
2024-06-13 4:11 ` [PATCH 17/19] NFSv4: Ask for a delegation or an open stateid in OPEN trondmy
2024-06-13 4:11 ` [PATCH 18/19] NFS: Add a generic callback to return the delegation trondmy
2024-06-13 4:11 ` [PATCH 19/19] Return the delegation when deleting the sillyrenamed file trondmy
2024-06-14 16:32 ` [PATCH 12/19] NFSv4: Fix up delegated attributes in nfs_setattr Anna Schumaker
2024-06-14 19:59 ` Trond Myklebust
2024-06-15 0:25 ` Trond Myklebust
2024-06-13 20:26 ` [PATCH 07/19] NFSv4: Add support for delegated atime and mtime attributes Anna Schumaker
2024-06-14 12:34 ` [PATCH 00/19] OPEN optimisations and Attribute delegations Jeff Layton
2024-06-15 6:27 ` Christoph Hellwig
2024-06-17 1:39 ` Trond Myklebust [this message]
2024-06-17 5:35 ` hch
2024-06-15 6:25 ` Christoph Hellwig
2024-06-17 1:28 ` Trond Myklebust
2024-06-17 5:37 ` hch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cf0f94ff9259d2bd97d51291e420aa368a2e3d6f.camel@hammerspace.com \
--to=trondmy@hammerspace.com \
--cc=chuck.lever@oracle.com \
--cc=hch@infradead.org \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox