linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: Trond Myklebust <trond.myklebust@primarydata.com>,
	Anna Schumaker <anna.schumaker@netapp.com>,
	Jeff Layton <jlayton@poochiereds.net>,
	"J. Bruce Fields" <bfields@fieldses.org>,
	Christoph Hellwig <hch@infradead.org>
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH v4 00/10] locking fixups for NFS
Date: Wed, 30 Dec 2015 08:13:56 -0500	[thread overview]
Message-ID: <cover.1451480826.git.bcodding@redhat.com> (raw)

This set addresses a few NFS related locking issues as well as a couple
minor cleanups.  It does a bit of plumbing to make sure we can complete
unlocks after close when the fl_file may be unavailable, and it attempts to
always release locks even when a wait for oustanding IO is interrupted
before sending an unlock.  This can orphan a lock on a server, which might
mean a delay for matching lock NFS4, or require a server restart to clean up
that lock for NFS3.

Change for v4:
	- combine tests for fl_type into single switch on 02/10

Change for v3:
	- update a comment on open mode checking for flock() locks

Changes for v2:
	- the change to move do_vfs_lock() to a shared inline has been removed
	- added patch to set FL_CLOSE for flock unlock on close (08/10)
	- instead of keeping a copied list of deferred file_locks to unlock,
	  just send an unlock for the entire file if FL_CLOSE is set.


Benjamin Coddington (10):
  NFS4: remove a redundant lock range check
  NFS: Move the flock open mode check into nfs_flock()
  NFS: Pass nfs_open_context instead of file to the lock procs
  NFSv4: Pass nfs_open_context instead of nfs4_state to
    nfs4_proc_unlck()
  lockd: Plumb nfs_open_context into nlm client unlock
  lockd: Send the inode to nlmclnt_setlockargs()
  lockd: do_vfs_lock() only needs the inode
  locks: Set FL_CLOSE when removing flock locks on close()
  NFS: Deferred unlocks - always unlock on FL_CLOSE
  NFS: cleanup do_vfs_lock()

 fs/lockd/clntproc.c        |   41 ++++++++++++++++---------------
 fs/locks.c                 |    2 +-
 fs/nfs/file.c              |   58 ++++++++++++++++++++++++++++++++-----------
 fs/nfs/inode.c             |   22 ++++++++++++++++
 fs/nfs/nfs3proc.c          |    6 +---
 fs/nfs/nfs4proc.c          |   45 ++++++++++------------------------
 fs/nfs/pagelist.c          |    8 ++++-
 fs/nfs/proc.c              |    6 +---
 include/linux/lockd/bind.h |    3 +-
 include/linux/nfs_fs.h     |    3 ++
 include/linux/nfs_xdr.h    |    2 +-
 11 files changed, 116 insertions(+), 80 deletions(-)


             reply	other threads:[~2015-12-30 13:14 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-30 13:13 Benjamin Coddington [this message]
2015-12-30 13:13 ` [PATCH v4 01/10] NFS4: remove a redundant lock range check Benjamin Coddington
2016-01-03 12:00   ` Christoph Hellwig
2015-12-30 13:13 ` [PATCH v4 02/10] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2016-01-03 12:01   ` Christoph Hellwig
2015-12-30 13:13 ` [PATCH v4 03/10] NFS: Pass nfs_open_context instead of file to the lock procs Benjamin Coddington
2016-01-03 12:02   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 04/10] NFSv4: Pass nfs_open_context instead of nfs4_state to nfs4_proc_unlck() Benjamin Coddington
2016-01-03 12:02   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 05/10] lockd: Plumb nfs_open_context into nlm client unlock Benjamin Coddington
2016-01-03 12:03   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 06/10] lockd: Send the inode to nlmclnt_setlockargs() Benjamin Coddington
2016-01-03 12:04   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 07/10] lockd: do_vfs_lock() only needs the inode Benjamin Coddington
2016-01-03 12:04   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 08/10] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2016-01-03 12:05   ` Christoph Hellwig
2015-12-30 13:14 ` [PATCH v4 09/10] NFS: Deferred unlocks - always unlock on FL_CLOSE Benjamin Coddington
2016-01-05  3:30   ` Trond Myklebust
2016-01-05 13:48     ` Benjamin Coddington
2015-12-30 13:14 ` [PATCH v4 10/10] NFS: cleanup do_vfs_lock() Benjamin Coddington
2016-01-03 12:06   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1451480826.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=bfields@fieldses.org \
    --cc=hch@infradead.org \
    --cc=jlayton@poochiereds.net \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).