public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Coddington <bcodding@redhat.com>
To: trond.myklebust@hammerspace.com, anna.schumaker@netapp.com
Cc: linux-nfs@vger.kernel.org
Subject: [PATCH 0/3] COPY/CLONE pagecache invalidation
Date: Tue, 16 Nov 2021 08:49:21 -0500	[thread overview]
Message-ID: <cover.1637069577.git.bcodding@redhat.com> (raw)

I found a small issue on the client with generic/432 when testing a server
that supports COPY/CLONE but doesn't have the open file descriptor cache.
Our current knfsd server's cache causes the server to not immediately
hand out a read delegation after a COPY/COMMIT, CLOSE, OPEN, so I suspect
our normal testing didn't catch this issue.

The client bug can be exposed by adding 5 second delays after xfs_io
commands in generic/432, which gives the server enough time to clean up the
cache and give the delegation.

Benjamin Coddington (3):
  NFSv42: Fix pagecache invalidation after COPY/CLONE
  NFSv42: Don't drop NFS_INO_INVALID_CHANGE if we hold a delegation
  NFS: Add a tracepoint to show the results of nfs_set_cache_invalid()

 fs/nfs/inode.c     | 5 ++++-
 fs/nfs/nfs42proc.c | 8 ++++++--
 fs/nfs/nfstrace.h  | 1 +
 3 files changed, 11 insertions(+), 3 deletions(-)

-- 
2.31.1


             reply	other threads:[~2021-11-16 13:49 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-16 13:49 Benjamin Coddington [this message]
2021-11-16 13:49 ` [PATCH 1/3] NFSv42: Fix pagecache invalidation after COPY/CLONE Benjamin Coddington
2021-11-16 13:57   ` Trond Myklebust
2021-11-16 14:01     ` Benjamin Coddington
2021-11-16 14:06       ` Benjamin Coddington
2021-11-16 15:26         ` Trond Myklebust
2021-11-16 13:49 ` [PATCH 2/3] NFSv42: Don't drop NFS_INO_INVALID_CHANGE if we hold a delegation Benjamin Coddington
2021-11-16 14:03   ` Trond Myklebust
2021-11-16 14:12     ` Benjamin Coddington
2021-11-16 14:17       ` Trond Myklebust
2021-11-16 14:34         ` Benjamin Coddington
2021-11-16 14:49           ` Trond Myklebust
2021-11-16 15:15             ` Benjamin Coddington
2021-11-16 13:49 ` [PATCH 3/3] NFS: Add a tracepoint to show the results of nfs_set_cache_invalid() Benjamin Coddington

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=cover.1637069577.git.bcodding@redhat.com \
    --to=bcodding@redhat.com \
    --cc=anna.schumaker@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox