From: Josef Bacik <josef@toxicpanda.com>
To: trond.myklebust@hammerspace.com, anna@kernel.org,
linux-nfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v5 0/3] Make nfs stats visible in network NS
Date: Thu, 15 Feb 2024 14:57:29 -0500 [thread overview]
Message-ID: <cover.1708026931.git.josef@toxicpanda.com> (raw)
v1: https://lore.kernel.org/linux-nfs/cover.1706124811.git.josef@toxicpanda.com/
v2: https://lore.kernel.org/linux-nfs/cover.1706212207.git.josef@toxicpanda.com/
v3: https://lore.kernel.org/linux-nfs/cover.1706283674.git.josef@toxicpanda.com/
v4: https://lore.kernel.org/linux-nfs/cover.1706305686.git.josef@toxicpanda.com/
v4->v5:
- If we clone a client pass through their ->cl_stats so it's populated properly.
v3->v4:
- Fix a weird formatting thing that snuck into 1/3.
v2->v3:
- Split out the nfs and nfsd related changes into their own patches.
- Dropped the change adding sv_stats throuch svc_create()
- Changed the th_cnt to be global, re-arranged it's location.
v1->v2:
- rework the sunprc service creation to take a pointer to the sv_stats.
- dropped ->pg_stats from the svc_program.
- converted all of the nfsd global stats to per-network namespace.
- added the ability to point at a specific rpc_stat for rpc program creation.
- converted the rpc stats for nfs to per-network namespace.
-- Original email --
Hello,
We're currently deploying NFS internally and have run into some oddities with
our usage of containers. All of the services that mount and export NFS volumes
run inside of containers, specifically all the namespaces including network
namespaces. Our monitoring is done on a per-container basis, so we need access
to the nfs and nfsd stats that are under /proc/net/sunrpc. However these are
only tied to the init_net, which makes them invisible to containers in a
different network namespace.
Fix this so that these files are tied to the network namespace. This allows us
to avoid the hack of bind mounting the hosts /proc into the container in order
to do proper monitoring. Thanks,
Josef
Josef Bacik (3):
sunrpc: add a struct rpc_stats arg to rpc_create_args
nfs: expose /proc/net/sunrpc/nfs in net namespaces
nfs: make the rpc_stat per net namespace
fs/nfs/client.c | 5 ++++-
fs/nfs/inode.c | 8 ++++----
fs/nfs/internal.h | 2 --
fs/nfs/netns.h | 2 ++
include/linux/sunrpc/clnt.h | 1 +
net/sunrpc/clnt.c | 5 ++++-
6 files changed, 15 insertions(+), 8 deletions(-)
--
2.43.0
next reply other threads:[~2024-02-15 19:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 19:57 Josef Bacik [this message]
2024-02-15 19:57 ` [PATCH v5 1/3] sunrpc: add a struct rpc_stats arg to rpc_create_args Josef Bacik
2024-02-15 19:57 ` [PATCH v5 2/3] nfs: expose /proc/net/sunrpc/nfs in net namespaces Josef Bacik
2024-02-15 19:57 ` [PATCH v5 3/3] nfs: make the rpc_stat per net namespace Josef Bacik
2024-06-20 11:22 ` Petr Vorel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1708026931.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=anna@kernel.org \
--cc=kernel-team@fb.com \
--cc=linux-nfs@vger.kernel.org \
--cc=trond.myklebust@hammerspace.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).