From: Benjamin Coddington <bcodding@redhat.com>
To: linux-nfs@vger.kernel.org
Subject: [RFC PATCH 0/1] A rare failure to wake up sync tasks
Date: Wed, 10 Jul 2024 16:32:03 -0400 [thread overview]
Message-ID: <cover.1720643005.git.bcodding@redhat.com> (raw)
Hey all - RFC patch here because this race is very hard to reproduce so I
will be testing this for a few days before feeling certain that this fix
does the job.
Meantime, I'd love some feedback from any one that has mastered load/store
races. Do I really need a full smp_mb() here? I think I do because the
race is not to the tk_runstate's ACTIVE bit which is set under the queue
lock, but rather to the wait_queue_head.. I'd love to be corrected.
Comments much appreciated.. this problem has been very elusive to catch.
Benjamin Coddington (1):
SUNRPC: Fix a race to wake a sync task
net/sunrpc/sched.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
--
2.44.0
next reply other threads:[~2024-07-10 20:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-10 20:32 Benjamin Coddington [this message]
2024-07-10 20:32 ` [RFC PATCH 1/1] SUNRPC: Fix a race to wake a sync task Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1720643005.git.bcodding@redhat.com \
--to=bcodding@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox