From: Jeff Layton <jlayton@kernel.org>
To: Chuck Lever <cel@kernel.org>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH v1] Revert "SUNRPC: Use RMW bitops in single-threaded hot paths"
Date: Fri, 06 Jan 2023 12:57:57 -0500 [thread overview]
Message-ID: <d0ee3c7a4850246d72e88eeb3b88db40380507f2.camel@kernel.org> (raw)
In-Reply-To: <167302701777.4221.807573588471189662.stgit@klimt.1015granger.net>
On Fri, 2023-01-06 at 12:43 -0500, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
>
> The premise that "Once an svc thread is scheduled and executing an
> RPC, no other processes will touch svc_rqst::rq_flags" is false.
> svc_xprt_enqueue() examines the RQ_BUSY flag in scheduled nfsd
> threads when determining which thread to wake up next.
>
> Found via KCSAN.
>
> Fixes: 28df0988815f ("SUNRPC: Use RMW bitops in single-threaded hot paths")
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> fs/nfsd/nfs4proc.c | 7 +++----
> fs/nfsd/nfs4xdr.c | 2 +-
> net/sunrpc/auth_gss/svcauth_gss.c | 4 ++--
> net/sunrpc/svc.c | 6 +++---
> net/sunrpc/svc_xprt.c | 2 +-
> net/sunrpc/svcsock.c | 8 ++++----
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +-
> 7 files changed, 15 insertions(+), 16 deletions(-)
>
Makes sense.
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-01-06 17:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-06 17:43 [PATCH v1] Revert "SUNRPC: Use RMW bitops in single-threaded hot paths" Chuck Lever
2023-01-06 17:57 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d0ee3c7a4850246d72e88eeb3b88db40380507f2.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=cel@kernel.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox