From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 71A6F28C2D7 for ; Wed, 28 May 2025 15:28:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748446087; cv=none; b=FTPMzB/XAgBsqfYrFwu/IkdEXAkBV+rjm+sxmrGZ5h0v1TzsmzidLAGN/1w+MKhr4KzRRh3Upd67QaR8RVgxoJ7H6ocqYD5JaamVy8p7jsl4eiJsWrUUZLXNJsLk4byRFzK5W3jqbSwEghRSDMlcRSmDI3E9iDq27EH11M8Melw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748446087; c=relaxed/simple; bh=YcImnOuYPOp8uRdZOqKPrS66rkxVOWsYzZJ+DmpRi80=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=LgqDdy0VJULIRxK753AUZhc/gTrb40KkgHAQ54X8RQCl8b1EJgoAsrmOm9Z0E2XQC0EUY3whwsTvVjj8EmYbu0mwE7EtLMI3CzAxGGsuI3cHNyTtga0IIOD83jSqT8Licm4o6SWpF0f4kJLaL4/73dnXb3LxNSHB1XYlAkcd0Gs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=rSiWG+YY; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="rSiWG+YY" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B1DEC4CEE3; Wed, 28 May 2025 15:28:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1748446086; bh=YcImnOuYPOp8uRdZOqKPrS66rkxVOWsYzZJ+DmpRi80=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=rSiWG+YYzCk6NrzfjG930/MfjFXNa8n3c6TDuAMYvufYdvX1H37X6kaN0iIKHljyq G4OB1AAn5gsWlHY4E+I9i2G0zNRHxVqWo5YAjWmbwj53RJYQXU+z8P1ZtTSb9vtLsI FK6We+FqFK19gnD4Y9z5SbITDork405QjxSs8fdwxZmeVsNvwY27usuSuJgMzACxVm OKkvYq9X8k5KdFFj+Y11fOWh5GpT9WO4XtRv6E2xFmkbzVJ4TFwIqKhausLpsm5mfn LNcAde7UcEJHAG24ITMoDchUtAgp01s6cwTNKdz3NPBPu6jyOGziO5e4ScPqaQqZuZ /YB9PE3cZ++8A== Message-ID: Subject: Re: [PATCH v2 2/3] nfs: Add timecreate to nfs inode From: Jeff Layton To: Benjamin Coddington , Trond Myklebust Cc: Anna Schumaker , linux-nfs@vger.kernel.org, Lance Shelton Date: Wed, 28 May 2025 11:27:51 -0400 In-Reply-To: References: Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Wed, 2025-05-28 at 11:13 -0400, Benjamin Coddington wrote: > On 28 May 2025, at 8:56, Jeff Layton wrote: >=20 > > On Wed, 2025-05-28 at 08:50 -0400, Benjamin Coddington wrote: > > > From: Anne Marie Merritt > > >=20 > > > Add tracking of the create time (a.k.a. btime) along with correspondi= ng > > > bitfields, request, and decode xdr routines. > > >=20 > > > Signed-off-by: Anne Marie Merritt > > > Signed-off-by: Lance Shelton > > > Signed-off-by: Trond Myklebust > > > --- > > > fs/nfs/inode.c | 28 ++++++++++++++++++++++------ > > > fs/nfs/nfs4proc.c | 14 +++++++++++++- > > > fs/nfs/nfs4xdr.c | 24 ++++++++++++++++++++++++ > > > fs/nfs/nfstrace.h | 3 ++- > > > include/linux/nfs_fs.h | 7 +++++++ > > > include/linux/nfs_xdr.h | 3 +++ > > > 6 files changed, 71 insertions(+), 8 deletions(-) > > >=20 > > > diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c > > > index 160f3478a835..fd84c24963b3 100644 > > > --- a/fs/nfs/inode.c > > > +++ b/fs/nfs/inode.c > > > @@ -197,6 +197,7 @@ void nfs_set_cache_invalid(struct inode *inode, u= nsigned long flags) > > > if (!(flags & NFS_INO_REVAL_FORCED)) > > > flags &=3D ~(NFS_INO_INVALID_MODE | > > > NFS_INO_INVALID_OTHER | > > > + NFS_INO_INVALID_BTIME | > > > NFS_INO_INVALID_XATTR); > > > flags &=3D ~(NFS_INO_INVALID_CHANGE | NFS_INO_INVALID_SIZE); > > > } > > > @@ -522,6 +523,7 @@ nfs_fhget(struct super_block *sb, struct nfs_fh *= fh, struct nfs_fattr *fattr) > > > inode_set_atime(inode, 0, 0); > > > inode_set_mtime(inode, 0, 0); > > > inode_set_ctime(inode, 0, 0); > > > + memset(&nfsi->btime, 0, sizeof(nfsi->btime)); > > > inode_set_iversion_raw(inode, 0); > > > inode->i_size =3D 0; > > > clear_nlink(inode); > > > @@ -545,6 +547,10 @@ nfs_fhget(struct super_block *sb, struct nfs_fh = *fh, struct nfs_fattr *fattr) > > > inode_set_ctime_to_ts(inode, fattr->ctime); > > > else if (fattr_supported & NFS_ATTR_FATTR_CTIME) > > > nfs_set_cache_invalid(inode, NFS_INO_INVALID_CTIME); > > > + if (fattr->valid & NFS_ATTR_FATTR_BTIME) > > > + nfsi->btime =3D fattr->btime; > > > + else if (fattr_supported & NFS_ATTR_FATTR_BTIME) > > > + nfs_set_cache_invalid(inode, NFS_INO_INVALID_BTIME); > > > if (fattr->valid & NFS_ATTR_FATTR_CHANGE) > > > inode_set_iversion_raw(inode, fattr->change_attr); > > > else > > > @@ -1900,7 +1906,7 @@ static int nfs_inode_finish_partial_attr_update= (const struct nfs_fattr *fattr, > > > NFS_INO_INVALID_ATIME | NFS_INO_INVALID_CTIME | > > > NFS_INO_INVALID_MTIME | NFS_INO_INVALID_SIZE | > > > NFS_INO_INVALID_BLOCKS | NFS_INO_INVALID_OTHER | > > > - NFS_INO_INVALID_NLINK; > > > + NFS_INO_INVALID_NLINK | NFS_INO_INVALID_BTIME; > > > unsigned long cache_validity =3D NFS_I(inode)->cache_validity; > > > enum nfs4_change_attr_type ctype =3D NFS_SERVER(inode)->change_attr= _type; > > >=20 > > > @@ -2219,10 +2225,13 @@ static int nfs_update_inode(struct inode *ino= de, struct nfs_fattr *fattr) > > > nfs_fattr_fixup_delegated(inode, fattr); > > >=20 > > > save_cache_validity =3D nfsi->cache_validity; > > > - nfsi->cache_validity &=3D ~(NFS_INO_INVALID_ATTR > > > - | NFS_INO_INVALID_ATIME > > > - | NFS_INO_REVAL_FORCED > > > - | NFS_INO_INVALID_BLOCKS); > > > + nfsi->cache_validity &=3D > > > + ~(NFS_INO_INVALID_ATIME | NFS_INO_REVAL_FORCED | > > > + NFS_INO_INVALID_CHANGE | NFS_INO_INVALID_CTIME | > > > + NFS_INO_INVALID_MTIME | NFS_INO_INVALID_SIZE | > > > + NFS_INO_INVALID_OTHER | NFS_INO_INVALID_BLOCKS | > > > + NFS_INO_INVALID_NLINK | NFS_INO_INVALID_MODE | > > > + NFS_INO_INVALID_BTIME); > > >=20 > >=20 > > The delta above is a little curious. This patch is just adding > > NFS_INO_INVALID_BTIME, but the patch above adds the clearing of several > > other bits as well. Why does this logic change? >=20 > Good point, I wonder if it was based on other attribute work at the time, > the original was here: > https://lore.kernel.org/linux-nfs/20211227190504.309612-3-trondmy@kernel.= org/ >=20 > So I think what we're doing here is clearing what we know we don't have t= o > check/update - I think we can drop this entire hunk, its a minor > optimization, but hopefully we can get some expert opinion. Trond, do y= ou > want me to test with this hunk removed? Looking little closer, I think what happened there is that NFS_INO_INVALID_ATTR got unrolled into individual attr flags. So there may be no net change here (other than adding BTIME). Still, it'd be best to do that in a separate patch, IMO, esp. since this is in nfs_update_inode(), which is already so "fiddly". --=20 Jeff Layton