linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: YueHaibing <yuehaibing@huawei.com>
To: NeilBrown <neilb@suse.de>
Cc: <chuck.lever@oracle.com>, <jlayton@kernel.org>,
	<kolga@netapp.com>, <Dai.Ngo@oracle.com>, <tom@talpey.com>,
	<trond.myklebust@hammerspace.com>, <anna@kernel.org>,
	<linux-nfs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH -next] sunrpc: Remove unused extern declarations
Date: Mon, 24 Jul 2023 14:45:07 +0800	[thread overview]
Message-ID: <d8178e7c-d0ec-9e5d-9367-53f554e0392e@huawei.com> (raw)
In-Reply-To: <169017533908.11078.1160756498004010060@noble.neil.brown.name>

On 2023/7/24 13:08, NeilBrown wrote:
> On Sat, 22 Jul 2023, YueHaibing wrote:
>> Since commit 49b28684fdba ("nfsd: Remove deprecated nfsctl system call and related code.")
>> these declarations are unused, so can remove it.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Thanks.
> Could you remove the declaration of auth_unix_lookup too?
> It was removed in that commit, but the declaration is still with us.

Sure, will do this.
> 
> Thanks!
> NeilBrown
> 
>> ---
>>  include/linux/sunrpc/svcauth.h | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/include/linux/sunrpc/svcauth.h b/include/linux/sunrpc/svcauth.h
>> index 6d9cc9080aca..2402b7ca5d1a 100644
>> --- a/include/linux/sunrpc/svcauth.h
>> +++ b/include/linux/sunrpc/svcauth.h
>> @@ -157,11 +157,9 @@ extern void	svc_auth_unregister(rpc_authflavor_t flavor);
>>  
>>  extern struct auth_domain *unix_domain_find(char *name);
>>  extern void auth_domain_put(struct auth_domain *item);
>> -extern int auth_unix_add_addr(struct net *net, struct in6_addr *addr, struct auth_domain *dom);
>>  extern struct auth_domain *auth_domain_lookup(char *name, struct auth_domain *new);
>>  extern struct auth_domain *auth_domain_find(char *name);
>>  extern struct auth_domain *auth_unix_lookup(struct net *net, struct in6_addr *addr);
>> -extern int auth_unix_forget_old(struct auth_domain *dom);
>>  extern void svcauth_unix_purge(struct net *net);
>>  extern void svcauth_unix_info_release(struct svc_xprt *xpt);
>>  extern int svcauth_unix_set_client(struct svc_rqst *rqstp);
>> -- 
>> 2.34.1
>>
>>
> 
> .
> 

  reply	other threads:[~2023-07-24  6:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-22  3:31 [PATCH -next] sunrpc: Remove unused extern declarations YueHaibing
2023-07-22 15:34 ` Chuck Lever
2023-07-24  5:08 ` NeilBrown
2023-07-24  6:45   ` YueHaibing [this message]
2023-07-24 13:25     ` Chuck Lever
2023-07-24 13:59       ` YueHaibing

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d8178e7c-d0ec-9e5d-9367-53f554e0392e@huawei.com \
    --to=yuehaibing@huawei.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=anna@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=kolga@netapp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    --cc=tom@talpey.com \
    --cc=trond.myklebust@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).