Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] mount.nfs: Fix auto protocol negotiation
Date: Wed, 11 Apr 2018 10:18:46 -0400	[thread overview]
Message-ID: <da0256cc-626c-2a18-b0a8-1f8bb302ac05@RedHat.com> (raw)
In-Reply-To: <20180410142952.10657-1-steved@redhat.com>



On 04/10/2018 10:29 AM, Steve Dickson wrote:
> Commit 71b807e1 introduce a regression that
> caused v3 not to be tried when v4 was not
> supported by the server during auto negation.
> 
> A check of the type in nfs_nfs_version() was
> reverted back to only check for the "nfs4"
> string not the "nfs" string which fixed the
> problem.
> 
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed... 

steved.

> ---
>  utils/mount/network.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/utils/mount/network.c b/utils/mount/network.c
> index 9a2c878..e490399 100644
> --- a/utils/mount/network.c
> +++ b/utils/mount/network.c
> @@ -1279,8 +1279,8 @@ nfs_nfs_version(char *type, struct mount_options *options, struct nfs_version *v
>  		}
>  	}
>  
> -	if (!found && strncmp(type, "nfs", 3) == 0)
> -		version_val = "4";
> +	if (!found && strcmp(type, "nfs4") == 0)
> +		version_val = type + 3;
>  	else if (!found)
>  		return 1;
>  	else if (i <= 2 ) {
> 

      reply	other threads:[~2018-04-11 14:18 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-10 14:29 [PATCH] mount.nfs: Fix auto protocol negotiation Steve Dickson
2018-04-11 14:18 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=da0256cc-626c-2a18-b0a8-1f8bb302ac05@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox