Re: [PATCH 1/1] NFS: New mount option force_rdirplus

[Trond Myklebust <trondmy@hammerspace.com>]

On Wed, 2025-03-12 at 18:57 -0400, Benjamin Coddington wrote:
> On 12 Mar 2025, at 18:48, Trond Myklebust wrote:
> 
> > On Wed, 2025-03-12 at 15:46 -0400, Benjamin Coddington wrote:
> > > There are certain users that wish to force the NFS client to
> > > choose
> > > READDIRPLUS over READDIR for a particular mount.  Add a new
> > > kernel
> > > mount
> > > option "force_rdirplus" to carry that intent.
> > 
> > Could we perhaps convert rdirplus to be a string with an optional
> > payload? Does the "fs_param_can_be_empty" flag allow you to convert
> > rdirplus into something that can behave as currently if you just
> > specify '-ordirplus', but that would allow you to specify '-
> > ordirplus=force' if you wanted to always use readdirplus?
> 
> Yes, I think that's possible.  I originally started down that route,
> but
> abandoned it after it appeared to be a bigger code diff because you
> have to
> re-define the nordirplus option which we get for free with
> fsparam_flag_no.
> 
> I can send a v2 that way if it's preferred.

To me that seems tidier, and easier to remember. It also allows you to
alias nordirplus as a 'rdirplus=none' option, should that be desirable.

-- 
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com