From: Jeff Layton <jlayton@kernel.org>
To: Li Lingfeng <lilingfeng3@huawei.com>,
trondmy@kernel.org, anna@kernel.org, chuck.lever@oracle.com,
neilb@suse.de, kolga@netapp.com, Dai.Ngo@oracle.com,
tom@talpey.com
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
yukuai1@huaweicloud.com, houtao1@huawei.com,
yi.zhang@huawei.com, yangerkun@huawei.com,
lilingfeng@huaweicloud.com
Subject: Re: [PATCH 1/4] nfsd: fix the comment of nfs_get_root
Date: Fri, 23 Aug 2024 08:06:20 -0400 [thread overview]
Message-ID: <dbc462ac55944c3ae82b07937b194673e61df626.camel@kernel.org> (raw)
In-Reply-To: <20240823070049.3499625-2-lilingfeng3@huawei.com>
On Fri, 2024-08-23 at 15:00 +0800, Li Lingfeng wrote:
> The comment for nfs_get_root() needs to be updated as it would also be
> used by NFS4 as follows:
> @x[
> nfs_get_root+1
> nfs_get_tree_common+1819
> nfs_get_tree+2594
> vfs_get_tree+73
> fc_mount+23
> do_nfs4_mount+498
> nfs4_try_get_tree+134
> nfs_get_tree+2562
> vfs_get_tree+73
> path_mount+2776
> do_mount+226
> __se_sys_mount+343
> __x64_sys_mount+106
> do_syscall_64+69
> entry_SYSCALL_64_after_hwframe+97
> , mount.nfs4]: 1
>
> Signed-off-by: Li Lingfeng <lilingfeng3@huawei.com>
> ---
> fs/nfs/getroot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/getroot.c b/fs/nfs/getroot.c
> index 11ff2b2e060f..f13d25d95b85 100644
> --- a/fs/nfs/getroot.c
> +++ b/fs/nfs/getroot.c
> @@ -62,7 +62,7 @@ static int nfs_superblock_set_dummy_root(struct super_block *sb, struct inode *i
> }
>
> /*
> - * get an NFS2/NFS3 root dentry from the root filehandle
> + * get a root dentry from the root filehandle
> */
> int nfs_get_root(struct super_block *s, struct fs_context *fc)
> {
Note that this is a NFS client patch, not a nfsd patch like the title
suggests.
Acked-by: Jeff Layton <jlayton@kernel.org>
next prev parent reply other threads:[~2024-08-23 12:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-23 7:00 [PATCH 0/4] nfsd: fix some comments and code cleanup Li Lingfeng
2024-08-23 7:00 ` [PATCH 1/4] nfsd: fix the comment of nfs_get_root Li Lingfeng
2024-08-23 12:06 ` Jeff Layton [this message]
2024-08-23 7:00 ` [PATCH 2/4] nfsd: fix some spelling errors in comments Li Lingfeng
2024-08-23 12:07 ` Jeff Layton
2024-08-24 0:54 ` Li Lingfeng
2024-08-23 7:00 ` [PATCH 3/4] nfsd: remove the redundant blank line Li Lingfeng
2024-08-23 12:08 ` Jeff Layton
2024-08-24 0:44 ` Li Lingfeng
2024-08-23 7:00 ` [PATCH 4/4] nfsd: remove unused parameter of nfsd_file_mark_find_or_create Li Lingfeng
2024-08-23 12:09 ` Jeff Layton
2024-08-23 16:39 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dbc462ac55944c3ae82b07937b194673e61df626.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=anna@kernel.org \
--cc=chuck.lever@oracle.com \
--cc=houtao1@huawei.com \
--cc=kolga@netapp.com \
--cc=lilingfeng3@huawei.com \
--cc=lilingfeng@huaweicloud.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
--cc=trondmy@kernel.org \
--cc=yangerkun@huawei.com \
--cc=yi.zhang@huawei.com \
--cc=yukuai1@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).