From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B019934C9A1 for ; Fri, 5 Dec 2025 17:41:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764956505; cv=none; b=AUUaFp+FknIgNxQW1BP+9V/7G0KcIR00q2A9XgUR++W0doTxgvk+3s/kDs/0yLqQmQ+vWlu9Lwdv7fhdPqUrP3yIOhEY/fCd31YJNr0vSIvYHw2Ey9FwXeV/w343lOrHtN8emy/IhirS/C9g268wDvEOMpwsamkYRnM3pmyUayE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764956505; c=relaxed/simple; bh=9P+oUCNrHqQr6TTse4VstKkT/97+r6l55NAKHEhSJ9s=; h=MIME-Version:Date:From:To:Cc:Message-Id:In-Reply-To:References: Subject:Content-Type; b=Tbl4rB6BjgDFuhGSp5e+V/GKaycAEmCjgMCu1DEMwO7DE0prLTLBm/IYc8Ul1CRaXeGWyeX1PyVxmJC+hH9JPlCjWLe7bq2TzVpdItmkMqyeDM8pron4jIeGi+i7AIV0GlTBYLZ4w4pqxymjdSTacVzTAZ+x1Sz8TIjBC5U6bYc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oviwmDWC; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oviwmDWC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E53E6C4CEF1; Fri, 5 Dec 2025 17:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1764956505; bh=9P+oUCNrHqQr6TTse4VstKkT/97+r6l55NAKHEhSJ9s=; h=Date:From:To:Cc:In-Reply-To:References:Subject:From; b=oviwmDWCzYHpDX4wfzofBRm9GQZKAOShMHLidMh2k622DxLjwkFlIM7xaUH3scOSl HGKqbb8km99rlq3YhJdBITxZUVpuzRWNcJUPi/8CDuqg2tewxk1AVtiuy3FrtKuasz F2dWGAQIB8nyBhVm2LOsz2w+qav4DPSd602h59UgGLrrC7Suxfz4ne01rVRBuaRtId X64UkjS1FTgRyNUPlBvaRhf3mfmBaXYE6B+jzs/GigOClyx0phyG58qSRUoLhMQY34 Ft4qC7vTIOwmqFGb/nREezZfPgBulqCFU0du0pZj1j9/b6iMKFf6sX+vI3REBLMCvU BCFVnYOc2uAyQ== Received: from phl-compute-10.internal (phl-compute-10.internal [10.202.2.50]) by mailfauth.phl.internal (Postfix) with ESMTP id F0FEEF4006C; Fri, 5 Dec 2025 12:41:43 -0500 (EST) Received: from phl-imap-15 ([10.202.2.104]) by phl-compute-10.internal (MEProxy); Fri, 05 Dec 2025 12:41:43 -0500 X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefgedrtddtgdeltddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfurfetoffkrfgpnffqhgenuceurghi lhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurh epofggfffhvfevkfgjfhfutgfgsehtjeertdertddtnecuhfhrohhmpedfvehhuhgtkhcu nfgvvhgvrhdfuceotggvlheskhgvrhhnvghlrdhorhhgqeenucggtffrrghtthgvrhhnpe fhffekffeftdfgheeiveekudeuhfdvjedvfedvueduvdegleekgeetgfduhfefleenucev lhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegthhhutghklh gvvhgvrhdomhgvshhmthhprghuthhhphgvrhhsohhnrghlihhthidqudeifeegleelleeh ledqfedvleekgeegvdefqdgtvghlpeepkhgvrhhnvghlrdhorhhgsehfrghsthhmrghilh drtghomhdpnhgspghrtghpthhtohepudejpdhmohguvgepshhmthhpohhuthdprhgtphht thhopehnvghilhessghrohifnhdrnhgrmhgvpdhrtghpthhtohepuggrvhgvmhesuggrvh gvmhhlohhfthdrnhgvthdprhgtphhtthhopegvughumhgriigvthesghhoohhglhgvrdgt ohhmpdhrtghpthhtoheprghnnhgrsehkvghrnhgvlhdrohhrghdprhgtphhtthhopehhoh hrmhhssehkvghrnhgvlhdrohhrghdprhgtphhtthhopehjlhgrhihtohhnsehkvghrnhgv lhdrohhrghdprhgtphhtthhopehkuhgsrgeskhgvrhhnvghlrdhorhhgpdhrtghpthhtoh epthhrohhnughmhieskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepiihhrghotghhvghn ghhurghngheskhihlhhinhhoshdrtghn X-ME-Proxy: Feedback-ID: ifa6e4810:Fastmail Received: by mailuser.phl.internal (Postfix, from userid 501) id C9429780054; Fri, 5 Dec 2025 12:41:43 -0500 (EST) X-Mailer: MessagingEngine.com Webmail Interface Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-ThreadId: AyOyYelYpCes Date: Fri, 05 Dec 2025 12:41:21 -0500 From: "Chuck Lever" To: "Chenguang Zhao" , "Trond Myklebust" , "Anna Schumaker" , "Chuck Lever" , "Jeff Layton" , NeilBrown , "Olga Kornievskaia" , "Dai Ngo" , "Tom Talpey" , "David S. Miller" , "Eric Dumazet" , "Jakub Kicinski" , "Paolo Abeni" , "Simon Horman" Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: In-Reply-To: <20251204011232.41487-1-zhaochenguang@kylinos.cn> References: <20251204011232.41487-1-zhaochenguang@kylinos.cn> Subject: Re: [PATCH RESEND linux-next] SUNRPC: Optimize list definition method Content-Type: text/plain Content-Transfer-Encoding: 7bit On Wed, Dec 3, 2025, at 8:12 PM, Chenguang Zhao wrote: > Integrate list definition and initialization into LIST_HEAD macro > > Signed-off-by: Chenguang Zhao > --- > net/sunrpc/backchannel_rqst.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/net/sunrpc/backchannel_rqst.c b/net/sunrpc/backchannel_rqst.c > index caa94cf57123..949022c5574c 100644 > --- a/net/sunrpc/backchannel_rqst.c > +++ b/net/sunrpc/backchannel_rqst.c > @@ -131,7 +131,7 @@ EXPORT_SYMBOL_GPL(xprt_setup_backchannel); > int xprt_setup_bc(struct rpc_xprt *xprt, unsigned int min_reqs) > { > struct rpc_rqst *req; > - struct list_head tmp_list; > + LIST_HEAD(tmp_list); > int i; > > dprintk("RPC: setup backchannel transport\n"); > @@ -147,7 +147,6 @@ int xprt_setup_bc(struct rpc_xprt *xprt, unsigned > int min_reqs) > * lock is held on the rpc_xprt struct. It also makes cleanup > * easier in case of memory allocation errors. > */ > - INIT_LIST_HEAD(&tmp_list); > for (i = 0; i < min_reqs; i++) { > /* Pre-allocate one backchannel rpc_rqst */ > req = xprt_alloc_bc_req(xprt); > -- > 2.25.1 The commit message: > SUNRPC: Optimize list definition method > > Integrate list definition and initialization into LIST_HEAD macro Only describes what the change does, not why it's needed. The body just restates the diff in English. A commit message should justify the change. For this patch, there's no justification. Moreover the word "Optimize" in the subject is misleading - it implies a benefit that doesn't exist. If this change were genuinely needed, the commit message should explain something like: - "...to match the pattern used elsewhere in this file" (if applicable) - "...as a prerequisite for X" - "...to fix Y" For example, is this patch part of a kernel-wide audit driven by a code safety concern? -- Chuck Lever