linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: trondmy@kernel.org, anna@kernel.org
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
Date: Wed, 21 Aug 2024 08:20:29 -0400	[thread overview]
Message-ID: <ddf1b7a06b9f67635a42b57d2c7e1042a9eeffb2.camel@kernel.org> (raw)
In-Reply-To: <20240815141841.29620-1-jlayton@kernel.org>

On Thu, 2024-08-15 at 10:18 -0400, Jeff Layton wrote:
> The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the initial
> SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
> request.
> 
> Fixes: 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
>  fs/nfs/nfs4proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 8883016c551c..39ad7780986c 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f
>  		     FATTR4_WORD0_CASE_INSENSITIVE |
>  		     FATTR4_WORD0_CASE_PRESERVING;
>  	if (minorversion)
> -		bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT;
> +		bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT | FATTR4_WORD2_OPEN_ARGUMENTS;
>  
>  	status = nfs4_call_sync(server->client, server, &msg, &args.seq_args, &res.seq_res, 0);
>  	if (status == 0) {

Ping? It would be nice to have this fixed before v6.11 ships.
-- 
Jeff Layton <jlayton@kernel.org>

  reply	other threads:[~2024-08-21 12:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-15 14:18 [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS Jeff Layton
2024-08-21 12:20 ` Jeff Layton [this message]
2024-08-21 19:30   ` Anna Schumaker
2024-08-21 16:04 ` Benjamin Coddington
2024-08-21 16:06   ` Jeff Layton
2024-08-21 16:18     ` Trond Myklebust

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ddf1b7a06b9f67635a42b57d2c7e1042a9eeffb2.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=anna@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).