* [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
@ 2024-08-15 14:18 Jeff Layton
2024-08-21 12:20 ` Jeff Layton
2024-08-21 16:04 ` Benjamin Coddington
0 siblings, 2 replies; 6+ messages in thread
From: Jeff Layton @ 2024-08-15 14:18 UTC (permalink / raw)
To: trondmy, anna; +Cc: linux-nfs
The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the initial
SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
request.
Fixes: 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)
Signed-off-by: Jeff Layton <jlayton@kernel.org>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index 8883016c551c..39ad7780986c 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f
FATTR4_WORD0_CASE_INSENSITIVE |
FATTR4_WORD0_CASE_PRESERVING;
if (minorversion)
- bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT;
+ bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT | FATTR4_WORD2_OPEN_ARGUMENTS;
status = nfs4_call_sync(server->client, server, &msg, &args.seq_args, &res.seq_res, 0);
if (status == 0) {
--
2.46.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
2024-08-15 14:18 [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS Jeff Layton
@ 2024-08-21 12:20 ` Jeff Layton
2024-08-21 19:30 ` Anna Schumaker
2024-08-21 16:04 ` Benjamin Coddington
1 sibling, 1 reply; 6+ messages in thread
From: Jeff Layton @ 2024-08-21 12:20 UTC (permalink / raw)
To: trondmy, anna; +Cc: linux-nfs
On Thu, 2024-08-15 at 10:18 -0400, Jeff Layton wrote:
> The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the initial
> SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
> request.
>
> Fixes: 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 8883016c551c..39ad7780986c 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f
> FATTR4_WORD0_CASE_INSENSITIVE |
> FATTR4_WORD0_CASE_PRESERVING;
> if (minorversion)
> - bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT;
> + bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT | FATTR4_WORD2_OPEN_ARGUMENTS;
>
> status = nfs4_call_sync(server->client, server, &msg, &args.seq_args, &res.seq_res, 0);
> if (status == 0) {
Ping? It would be nice to have this fixed before v6.11 ships.
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
2024-08-21 12:20 ` Jeff Layton
@ 2024-08-21 19:30 ` Anna Schumaker
0 siblings, 0 replies; 6+ messages in thread
From: Anna Schumaker @ 2024-08-21 19:30 UTC (permalink / raw)
To: Jeff Layton; +Cc: trondmy, linux-nfs
On Wed, Aug 21, 2024 at 8:20 AM Jeff Layton <jlayton@kernel.org> wrote:
>
> On Thu, 2024-08-15 at 10:18 -0400, Jeff Layton wrote:
> > The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the initial
> > SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
> > request.
> >
> > Fixes: 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> > ---
> > fs/nfs/nfs4proc.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> > index 8883016c551c..39ad7780986c 100644
> > --- a/fs/nfs/nfs4proc.c
> > +++ b/fs/nfs/nfs4proc.c
> > @@ -3931,7 +3931,7 @@ static int _nfs4_server_capabilities(struct nfs_server *server, struct nfs_fh *f
> > FATTR4_WORD0_CASE_INSENSITIVE |
> > FATTR4_WORD0_CASE_PRESERVING;
> > if (minorversion)
> > - bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT;
> > + bitmask[2] = FATTR4_WORD2_SUPPATTR_EXCLCREAT | FATTR4_WORD2_OPEN_ARGUMENTS;
> >
> > status = nfs4_call_sync(server->client, server, &msg, &args.seq_args, &res.seq_res, 0);
> > if (status == 0) {
>
> Ping? It would be nice to have this fixed before v6.11 ships.
This and your other patch both look good to me. I'll try to get out a
bugfixes pull request by the end of the week!
Anna
> --
> Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
2024-08-15 14:18 [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS Jeff Layton
2024-08-21 12:20 ` Jeff Layton
@ 2024-08-21 16:04 ` Benjamin Coddington
2024-08-21 16:06 ` Jeff Layton
1 sibling, 1 reply; 6+ messages in thread
From: Benjamin Coddington @ 2024-08-21 16:04 UTC (permalink / raw)
To: Jeff Layton; +Cc: trondmy, anna, linux-nfs
On 15 Aug 2024, at 10:18, Jeff Layton wrote:
> The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the initial
> SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
> request.
>
> Fixes: 707f13b3d081 (NFSv4: Add support for the FATTR4_OPEN_ARGUMENTS attribute)
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
Clearly correct, save for slight style mismatch.
Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
Ben
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
2024-08-21 16:04 ` Benjamin Coddington
@ 2024-08-21 16:06 ` Jeff Layton
2024-08-21 16:18 ` Trond Myklebust
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Layton @ 2024-08-21 16:06 UTC (permalink / raw)
To: Benjamin Coddington; +Cc: trondmy, anna, linux-nfs
On Wed, 2024-08-21 at 12:04 -0400, Benjamin Coddington wrote:
> On 15 Aug 2024, at 10:18, Jeff Layton wrote:
>
> > The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the
> > initial
> > SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the initial
> > request.
> >
> > Fixes: 707f13b3d081 (NFSv4: Add support for the
> > FATTR4_OPEN_ARGUMENTS attribute)
> > Signed-off-by: Jeff Layton <jlayton@kernel.org>
>
> Clearly correct, save for slight style mismatch.
>
> Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
>
> Ben
>
Thanks. I noticed that after sending it. No objection if you want to
fix that up before merging.
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS
2024-08-21 16:06 ` Jeff Layton
@ 2024-08-21 16:18 ` Trond Myklebust
0 siblings, 0 replies; 6+ messages in thread
From: Trond Myklebust @ 2024-08-21 16:18 UTC (permalink / raw)
To: jlayton@kernel.org, bcodding@redhat.com
Cc: anna@kernel.org, linux-nfs@vger.kernel.org
On Wed, 2024-08-21 at 12:06 -0400, Jeff Layton wrote:
> On Wed, 2024-08-21 at 12:04 -0400, Benjamin Coddington wrote:
> > On 15 Aug 2024, at 10:18, Jeff Layton wrote:
> >
> > > The client doesn't properly request FATTR4_OPEN_ARGUMENTS in the
> > > initial
> > > SERVER_CAPS getattr. Add FATTR4_WORD2_OPEN_ARGUMENTS to the
> > > initial
> > > request.
> > >
> > > Fixes: 707f13b3d081 (NFSv4: Add support for the
> > > FATTR4_OPEN_ARGUMENTS attribute)
> > > Signed-off-by: Jeff Layton <jlayton@kernel.org>
> >
> > Clearly correct, save for slight style mismatch.
> >
> > Reviewed-by: Benjamin Coddington <bcodding@redhat.com>
> >
> > Ben
> >
>
> Thanks. I noticed that after sending it. No objection if you want to
> fix that up before merging.
Ack to this too.
--
Trond Myklebust
Linux NFS client maintainer, Hammerspace
trond.myklebust@hammerspace.com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2024-08-21 19:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-15 14:18 [PATCH] nfs: fix the fetch of FATTR4_OPEN_ARGUMENTS Jeff Layton
2024-08-21 12:20 ` Jeff Layton
2024-08-21 19:30 ` Anna Schumaker
2024-08-21 16:04 ` Benjamin Coddington
2024-08-21 16:06 ` Jeff Layton
2024-08-21 16:18 ` Trond Myklebust
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).