Linux NFS development
 help / color / mirror / Atom feed
From: Steve Dickson <steved@redhat.com>
To: Scott Mayhew <smayhew@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [nfs-utils PATCH] nfsiostat: normalize the mountpoints passed in from the command line
Date: Mon, 26 Jan 2026 08:36:55 -0500	[thread overview]
Message-ID: <deee43a9-dc5b-4b9f-ba04-0ef2dbf0a452@redhat.com> (raw)
In-Reply-To: <20260122170358.1121341-1-smayhew@redhat.com>



On 1/22/26 12:03 PM, Scott Mayhew wrote:
> If the mountpoint passed in from the command line contains a trailing
> '/' character, then nfsiostat winds up printing statistics for all
> mounts instead of printing statistics for the specific mount that was
> requested.
> 
> Signed-off-by: Scott Mayhew <smayhew@redhat.com>
Committed... (tag: nfs-utils-2-8-5-rc2)

steved.

> ---
>   tools/nfs-iostat/nfs-iostat.py | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/nfs-iostat/nfs-iostat.py b/tools/nfs-iostat/nfs-iostat.py
> index e46b1a83..69d24a11 100755
> --- a/tools/nfs-iostat/nfs-iostat.py
> +++ b/tools/nfs-iostat/nfs-iostat.py
> @@ -589,8 +589,8 @@ client are listed.
>   
>       (options, args) = parser.parse_args(sys.argv)
>       for arg in args[1:]:
> -        if arg in mountstats:
> -            origdevices += [arg]
> +        if os.path.normpath(arg) in mountstats:
> +            origdevices += [os.path.normpath(arg)]
>           elif not interval_seen:
>               try:
>                   interval = int(arg)


      reply	other threads:[~2026-01-26 13:37 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-22 17:03 [nfs-utils PATCH] nfsiostat: normalize the mountpoints passed in from the command line Scott Mayhew
2026-01-26 13:36 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=deee43a9-dc5b-4b9f-ba04-0ef2dbf0a452@redhat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=smayhew@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox