* [PATCH] nfs4: fix missing-braces warning
@ 2016-10-18 15:21 Arnd Bergmann
2016-10-19 18:51 ` Anna Schumaker
0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2016-10-18 15:21 UTC (permalink / raw)
To: Trond Myklebust
Cc: Arnd Bergmann, Anna Schumaker, Jeff Layton, Al Viro,
Andreas Gruenbacher, Andy Adamson, linux-nfs, linux-kernel
A bugfix introduced a harmless warning for update_open_stateid:
fs/nfs/nfs4proc.c:1548:2: error: missing braces around initializer [-Werror=missing-braces]
Removing the zero in the initializer will do the right thing here
and initialize the entire structure to zero.
Fixes: 1393d9612ba0 ("NFSv4: Fix a race when updating an open_stateid")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
fs/nfs/nfs4proc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
index ad917bd72b38..7897826d7c51 100644
--- a/fs/nfs/nfs4proc.c
+++ b/fs/nfs/nfs4proc.c
@@ -1545,7 +1545,7 @@ static int update_open_stateid(struct nfs4_state *state,
struct nfs_client *clp = server->nfs_client;
struct nfs_inode *nfsi = NFS_I(state->inode);
struct nfs_delegation *deleg_cur;
- nfs4_stateid freeme = {0};
+ nfs4_stateid freeme = { };
int ret = 0;
fmode &= (FMODE_READ|FMODE_WRITE);
--
2.9.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] nfs4: fix missing-braces warning
2016-10-18 15:21 [PATCH] nfs4: fix missing-braces warning Arnd Bergmann
@ 2016-10-19 18:51 ` Anna Schumaker
0 siblings, 0 replies; 2+ messages in thread
From: Anna Schumaker @ 2016-10-19 18:51 UTC (permalink / raw)
To: Arnd Bergmann, Trond Myklebust
Cc: Jeff Layton, Al Viro, Andreas Gruenbacher, Andy Adamson,
linux-nfs, linux-kernel
Hi Arnd (and Geert, if you're out there. I keep getting "relay access denied" when I try to CC you),
Thanks for the patches for this issue! I've applied Arnd's version for 4.9-rc* since I think it looks a little cleaner.
Cheers,
Anna
On 10/18/2016 11:21 AM, Arnd Bergmann wrote:
> A bugfix introduced a harmless warning for update_open_stateid:
>
> fs/nfs/nfs4proc.c:1548:2: error: missing braces around initializer [-Werror=missing-braces]
>
> Removing the zero in the initializer will do the right thing here
> and initialize the entire structure to zero.
>
> Fixes: 1393d9612ba0 ("NFSv4: Fix a race when updating an open_stateid")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> fs/nfs/nfs4proc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index ad917bd72b38..7897826d7c51 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -1545,7 +1545,7 @@ static int update_open_stateid(struct nfs4_state *state,
> struct nfs_client *clp = server->nfs_client;
> struct nfs_inode *nfsi = NFS_I(state->inode);
> struct nfs_delegation *deleg_cur;
> - nfs4_stateid freeme = {0};
> + nfs4_stateid freeme = { };
> int ret = 0;
>
> fmode &= (FMODE_READ|FMODE_WRITE);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-10-19 18:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 15:21 [PATCH] nfs4: fix missing-braces warning Arnd Bergmann
2016-10-19 18:51 ` Anna Schumaker
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).