Linux NFS development
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Greg KH <gregkh@linuxfoundation.org>,
	email200202 <email200202@yahoo.com>
Cc: regressions@lists.linux.dev, kernel@gentoo.org,
	stable@vger.kernel.org,  linux-nfs@vger.kernel.org
Subject: Re: [REGRESSION] After kernel upgrade 6.1.70 to 6.1.71, the computer hangs during shutdown
Date: Thu, 11 Jan 2024 12:26:39 -0500	[thread overview]
Message-ID: <e341cb408b5663d8c91b8fa57b41bb984be43448.camel@kernel.org> (raw)
In-Reply-To: <2024011127-excluding-bodacious-1950@gregkh>

On Thu, 2024-01-11 at 10:30 +0100, Greg KH wrote:
> On Thu, Jan 11, 2024 at 07:20:02PM +1100, email200202 wrote:
> > Reverting the following 3 commits fixed the problem in kernel 6.1.71:
> > 
> > f9a01938e07910224d4a2fd00583725d686c3f38
> > bb4f791cb2de1140d0fbcedfe9e791ff364021d7
> > 03d68ffc48b94cc1e15bbf3b4f16f1e1e4fa286a
> 
> When sending us git ids, please show the full context so we have a hint
> as to what they are.  For this, it should be:
> 
> f9a01938e079 ("NFSD: fix possible oops when nfsd/pool_stats is closed.")
> bb4f791cb2de ("nfsd: call nfsd_last_thread() before final nfsd_put()")
> 03d68ffc48b9 ("nfsd: separate nfsd_last_thread() from nfsd_put()")
> 
> Do you also have these issues in the latest 6.6.y release?  6.7?
> 
> 

I wasn't able to reproduce the exact same bug as the reporter, but I did
see a different panic due to the above patches. Some of those fixes
aren't appropriate without pulling in earlier commits, but I think it's
probably best to just drop these two:

bb4f791cb2de ("nfsd: call nfsd_last_thread() before final nfsd_put()")
03d68ffc48b9 ("nfsd: separate nfsd_last_thread() from nfsd_put()")

Greg, does that sound OK?

Thanks,
-- 
Jeff Layton <jlayton@kernel.org>

  parent reply	other threads:[~2024-01-11 17:26 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <58ac38ae-4d64-4a53-81e0-35785961c41c.ref@yahoo.com>
2024-01-11  8:20 ` [REGRESSION] After kernel upgrade 6.1.70 to 6.1.71, the computer hangs during shutdown email200202
2024-01-11  9:30   ` Greg KH
2024-01-11 10:10     ` email200202
2024-01-11 10:21       ` Greg KH
2024-01-11 13:58         ` email200202
2024-01-11 14:05           ` Chuck Lever III
2024-01-11 17:26     ` Jeff Layton [this message]
2024-01-13  9:35       ` Greg KH
2024-01-13  9:39         ` Greg KH
2024-01-19 10:13   ` Linux regression tracking #update (Thorsten Leemhuis)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e341cb408b5663d8c91b8fa57b41bb984be43448.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=email200202@yahoo.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=kernel@gentoo.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox