From: Jeff Layton <jlayton@kernel.org>
To: Olga Kornievskaia <okorniev@redhat.com>, chuck.lever@oracle.com
Cc: linux-nfs@vger.kernel.org, neilb@suse.de, Dai.Ngo@oracle.com,
tom@talpey.com
Subject: Re: [PATCH 1/1] nfsd: fix __fh_verify for localio
Date: Tue, 28 Jan 2025 12:10:05 -0500 [thread overview]
Message-ID: <e3dca75f18db11b2cc1c7da5b1e6441821533497.camel@kernel.org> (raw)
In-Reply-To: <20250128165806.15153-1-okorniev@redhat.com>
On Tue, 2025-01-28 at 11:58 -0500, Olga Kornievskaia wrote:
> __fh_verify() added a call to svc_xprt_set_valid() to help do connection
> management but during LOCALIO path rqstp argument is NULL, leading to
> NULL pointer dereferencing and a crash.
>
> Fixes: eccbbc7c00a5 ("nfsd: don't use sv_nrthreads in connection limiting calculations.")
> Signed-off-by: Olga Kornievskaia <okorniev@redhat.com>
> ---
> fs/nfsd/nfsfh.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index bf59f83c6224..91bf0e6d5895 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -381,8 +381,9 @@ __fh_verify(struct svc_rqst *rqstp,
> error = check_nfsd_access(exp, rqstp, may_bypass_gss);
> if (error)
> goto out;
> -
> - svc_xprt_set_valid(rqstp->rq_xprt);
> + /* During LOCALIO call to fh_verify will be called with a NULL rqstp */
> + if (rqstp)
> + svc_xprt_set_valid(rqstp->rq_xprt);
>
> /* Finally, check access permissions. */
> error = nfsd_permission(cred, exp, dentry, access);
Nice catch!
Reviewed-by: Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2025-01-28 17:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-28 16:58 [PATCH 1/1] nfsd: fix __fh_verify for localio Olga Kornievskaia
2025-01-28 17:05 ` cel
2025-01-28 17:10 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e3dca75f18db11b2cc1c7da5b1e6441821533497.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=okorniev@redhat.com \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox