Re: [PATCH v7 1/2] NFSD: use per-operation statidx for callback procedures

[Jeff Layton <jlayton@kernel.org>]

On Fri, 2026-03-13 at 12:31 -0400, Chuck Lever wrote:
> From: Chuck Lever <chuck.lever@oracle.com>
> 
> The callback RPC procedure table uses NFSPROC4_CB_##call for
> p_statidx, which maps CB_NULL to index 0 and every
> compound-based callback (CB_RECALL, CB_LAYOUT, CB_OFFLOAD,
> etc.) to index 1. All compound callback operations therefore
> share a single statistics counter, making per-operation
> accounting impossible.
> 
> Assign p_statidx from the NFSPROC4_CLNT_##proc enum instead,
> giving each callback operation its own counter slot. The
> counts array is already sized by ARRAY_SIZE(nfs4_cb_procedures),
> so no allocation change is needed.
> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
>  fs/nfsd/nfs4callback.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfs4callback.c b/fs/nfsd/nfs4callback.c
> index aea8bdd2fdc4..74effafdd0dc 100644
> --- a/fs/nfsd/nfs4callback.c
> +++ b/fs/nfsd/nfs4callback.c
> @@ -1016,7 +1016,7 @@ static int nfs4_xdr_dec_cb_offload(struct rpc_rqst *rqstp,
>  	.p_decode  = nfs4_xdr_dec_##restype,				\
>  	.p_arglen  = NFS4_enc_##argtype##_sz,				\
>  	.p_replen  = NFS4_dec_##restype##_sz,				\
> -	.p_statidx = NFSPROC4_CB_##call,				\
> +	.p_statidx = NFSPROC4_CLNT_##proc,				\
>  	.p_name    = #proc,						\
>  }
>  

Reviewed-by: Jeff Layton <jlayton@kernel.org>