From: Steve Dickson <SteveD@RedHat.com>
To: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] systemd: Afters are also needed for the Wants=network-online.target
Date: Wed, 26 Apr 2017 12:10:29 -0400 [thread overview]
Message-ID: <e5f3b642-3f79-5623-a09c-eb1f68f39372@RedHat.com> (raw)
In-Reply-To: <20170424152752.25730-1-steved@redhat.com>
On 04/24/2017 11:27 AM, Steve Dickson wrote:
> Commit 9d4fc3fb added Wants=network-online.target which
> is not enough to ensure the network is completely up
> before the NFS server is started. After=network-online.target
> is also needed.
>
> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1419351
>
> Signed-off-by: Steve Dickson <steved@redhat.com>
Committed...
steved
> ---
> systemd/nfs-mountd.service | 1 +
> systemd/nfs-server.service | 2 +-
> systemd/rpc-statd-notify.service | 2 +-
> systemd/rpc-statd.service | 2 +-
> 4 files changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/systemd/nfs-mountd.service b/systemd/nfs-mountd.service
> index fec0399..e8ece53 100644
> --- a/systemd/nfs-mountd.service
> +++ b/systemd/nfs-mountd.service
> @@ -4,6 +4,7 @@ DefaultDependencies=no
> Requires=proc-fs-nfsd.mount
> Wants=network-online.target
> After=proc-fs-nfsd.mount
> +After=network-online.target local-fs.target
> After=rpcbind.socket
> BindsTo=nfs-server.service
>
> diff --git a/systemd/nfs-server.service b/systemd/nfs-server.service
> index e6b8f58..136552b 100644
> --- a/systemd/nfs-server.service
> +++ b/systemd/nfs-server.service
> @@ -7,7 +7,7 @@ Wants=rpcbind.socket network-online.target
> Wants=rpc-statd.service nfs-idmapd.service
> Wants=rpc-statd-notify.service
>
> -After= local-fs.target
> +After= network-online.target local-fs.target
> After= proc-fs-nfsd.mount rpcbind.socket nfs-mountd.service
> After= nfs-idmapd.service rpc-statd.service
> Before= rpc-statd-notify.service
> diff --git a/systemd/rpc-statd-notify.service b/systemd/rpc-statd-notify.service
> index f54d4c5..687fe31 100644
> --- a/systemd/rpc-statd-notify.service
> +++ b/systemd/rpc-statd-notify.service
> @@ -2,7 +2,7 @@
> Description=Notify NFS peers of a restart
> DefaultDependencies=no
> Wants=network-online.target
> -After=local-fs.target network.target nss-lookup.target
> +After=local-fs.target network-online.target nss-lookup.target
>
> # if we run an nfs server, it needs to be running before we
> # tell clients that it has restarted.
> diff --git a/systemd/rpc-statd.service b/systemd/rpc-statd.service
> index 8cef022..f41ae20 100644
> --- a/systemd/rpc-statd.service
> +++ b/systemd/rpc-statd.service
> @@ -4,7 +4,7 @@ DefaultDependencies=no
> Conflicts=umount.target
> Requires=nss-lookup.target rpcbind.socket
> Wants=network-online.target
> -After=nss-lookup.target rpcbind.socket
> +After=network-online.target nss-lookup.target rpcbind.socket
>
> PartOf=nfs-utils.service
>
>
prev parent reply other threads:[~2017-04-26 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-24 15:27 [PATCH] systemd: Afters are also needed for the Wants=network-online.target Steve Dickson
2017-04-26 16:10 ` Steve Dickson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5f3b642-3f79-5623-a09c-eb1f68f39372@RedHat.com \
--to=steved@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).