From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Chuck Lever <chuck.lever@oracle.com>, Jeff Layton <jlayton@kernel.org>
Cc: linux-nfs@vger.kernel.org, regressions@lists.linux.dev,
it+linux-nfs@molgen.mpg.de
Subject: Re: NFSD: Unable to initialize client recovery tracking! (-110)
Date: Tue, 21 May 2024 11:55:34 +0200 [thread overview]
Message-ID: <e8ab863e-18a5-4c16-b0c8-a3ab6440a9f6@molgen.mpg.de> (raw)
In-Reply-To: <aaeae060-2be0-4b9f-818c-1b7d87e41a5f@molgen.mpg.de>
#regzbot ^introduced: 74fd48739d04
Dear Jeff,
Am 19.04.24 um 18:50 schrieb Paul Menzel:
> Since at least Linux 6.8-rc6, Linux logs the warning below:
>
> NFSD: Unable to initialize client recovery tracking! (-110)
>
> I haven’t had time to bisect yet, so if you have an idea, that’d be great.
74fd48739d0488e39ae18b0168720f449a06690c is the first bad commit
commit 74fd48739d0488e39ae18b0168720f449a06690c
Author: Jeff Layton <jlayton@kernel.org>
Date: Fri Oct 13 09:03:53 2023 -0400
nfsd: new Kconfig option for legacy client tracking
We've had a number of attempts at different NFSv4 client tracking
methods over the years, but now nfsdcld has emerged as the clear winner
since the others (recoverydir and the usermodehelper upcall) are
problematic.
As a case in point, the recoverydir backend uses MD5 hashes to encode
long form clientid strings, which means that nfsd repeatedly gets
dinged
on FIPS audits, since MD5 isn't considered secure. Its use of MD5
is not
cryptographically significant, so there is no danger there, but
allowing
us to compile that out allows us to sidestep the issue entirely.
As a prelude to eventually removing support for these client tracking
methods, add a new Kconfig option that enables them. Mark it deprecated
and make it default to N.
Acked-by: NeilBrown <neilb@suse.de>
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
fs/nfsd/Kconfig | 16 +++++++++
fs/nfsd/nfs4recover.c | 97
+++++++++++++++++++++++++++++++++------------------
fs/nfsd/nfsctl.c | 6 ++++
3 files changed, 85 insertions(+), 34 deletions(-)
`NFSD_LEGACY_CLIENT_TRACKING` is not set:
# CONFIG_NFSD_LEGACY_CLIENT_TRACKING is not set
Kind regards,
Paul
next prev parent reply other threads:[~2024-05-21 9:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-19 16:50 NFSD: Unable to initialize client recovery tracking! (-110) Paul Menzel
2024-05-21 9:55 ` Paul Menzel [this message]
2024-05-21 10:01 ` Jeff Layton
2024-05-24 11:16 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-24 12:46 ` Jeff Layton
2024-05-24 16:09 ` Chuck Lever III
2024-05-29 12:51 ` Linux regression tracking (Thorsten Leemhuis)
2024-05-29 13:13 ` Jeff Layton
2024-05-29 13:16 ` Chuck Lever III
2024-05-29 13:27 ` Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e8ab863e-18a5-4c16-b0c8-a3ab6440a9f6@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=chuck.lever@oracle.com \
--cc=it+linux-nfs@molgen.mpg.de \
--cc=jlayton@kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=regressions@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).