public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Layton <jlayton@kernel.org>
To: Rick Macklem <rick.macklem@gmail.com>,
	Takeshi Nishimura <takeshi.nishimura.linux@gmail.com>
Cc: Linux NFS Mailing List <linux-nfs@vger.kernel.org>
Subject: Re: BUG: Linux 6.12 nfsd does not support FATTR4_WORD2_CHANGE_ATTR_TYPE in NFSv4.2 mode!!
Date: Mon, 13 Jan 2025 07:27:24 -0500	[thread overview]
Message-ID: <e94cda033ea733f5aca11538a97bec6bc1608165.camel@kernel.org> (raw)
In-Reply-To: <CAM5tNy5QamjN6xab3vESQmZJGD2+JgjXvn+qQit=AncG=fTPGg@mail.gmail.com>

On Sat, 2025-01-11 at 13:17 -0800, Rick Macklem wrote:
> On Sat, Jan 11, 2025 at 12:08 PM Takeshi Nishimura
> <takeshi.nishimura.linux@gmail.com> wrote:
> > 
> > Dear list,
> > 
> > We tried to use FATTR4_WORD2_CHANGE_ATTR_TYPE with Linux 6.12 nfsd,
> > but the server does not set that attribute, while it is mandatory for
> > NFSv4.2.
> My understand is that nothing is mandatory in NFSv4.2. Everything is considered
> optional extensions. I doubt any extant 4.2 server supports all of the optional
> extensions in NFSv4.2.
> 

Correct. This attr is completely optional.

> > Could this please be fixed?
> I'll leave if/when this optional extension will be added to the Linux
> knfsd to the
> Linux folk.
> 

See:

    1631087ba872 Revert "nfsd4: support change_attr_type attribute"

Upshot: we had this at one point, but ripped it out because it was't
terribly useful and could be problematic if the clock jumps backward.
We could add it back in again, but we'd need to understand how to
address the problems that Bruce points out.

-- 
Jeff Layton <jlayton@kernel.org>

  parent reply	other threads:[~2025-01-13 12:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-11 20:08 BUG: Linux 6.12 nfsd does not support FATTR4_WORD2_CHANGE_ATTR_TYPE in NFSv4.2 mode!! Takeshi Nishimura
2025-01-11 21:17 ` Rick Macklem
2025-01-13  4:06   ` Takeshi Nishimura
2025-01-13 12:34     ` Jeff Layton
2025-01-13 13:54     ` Chuck Lever
2025-01-13 12:27   ` Jeff Layton [this message]
2025-01-12 18:30 ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e94cda033ea733f5aca11538a97bec6bc1608165.camel@kernel.org \
    --to=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=rick.macklem@gmail.com \
    --cc=takeshi.nishimura.linux@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox