linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sricharan R <r.sricharan@ti.com>
To: linux-omap@vger.kernel.org, linux-nfs@vger.kernel.org
Cc: Trond.Myklebust@netapp.com
Subject: Regression seen when HIGHMEM enabled with NFS on 3.1rc4 kernel
Date: Fri, 9 Sep 2011 18:12:44 +0530	[thread overview]
Message-ID: <ef6baf9c7c0f44d1d50e3f65c6b038be@mail.gmail.com> (raw)

Hi,
  A kernel crash is observed on 3.1rc4 kernel when HIGHMEM is enabled and
  kernel is booted with a NFS on omap4430sdp. The issue happens in the
below
  scenario.

       In file net/sunrpc/xprtsock.c,
         static int xs_send_pagedata( xxx, struct xdr_buf *xdr, ..)
         {
		Struct page **ppage;
		....
		.....
		ppage = xdr->pages + (base >> PAGE_SHIFT);
		....
            err = sock->ops->sendpage(sock, *ppage, base, len, flags);

            ...
         }

         1) In the above piece of code, the *ppage value from
ops->sendpage 		function is finally passed on to Kmap by the lower
level code to 		get the virtual address of the page.
	   2) In some corner cases the value of *ppage pointer is NULL.
         3) When highmem is enabled and a NULL pointer is passed to
            Kmap, then kmap finally crashes. But in the case when highmem
            is disabled, then kmap returns a junk value for NULL pointer.

               Highmem Enabled , kmap( NULL )-----> kernel crashes.

               Highmem disabled, kmap( NULL )-----> junk value is
returned.
		   				Subsequently this message
is observed on
						the console.

		                        "RPC call returned error 14"

         4) Now the question is why is the value of *ppage = NULL is
passed
		from the above piece of code to lower layers.
           Should that not have handled *ppage = NULL? and kmap should not
have received a NULL pointer?

Thanks,
  Sricharan

             reply	other threads:[~2011-09-09 12:42 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-09 12:42 Sricharan R [this message]
  -- strict thread matches above, loose matches on Subject: below --
2011-09-09 13:10 Regression seen when HIGHMEM enabled with NFS on 3.1rc4 kernel R, Sricharan
2011-09-09 18:51 ` Trond Myklebust
2011-09-12  6:16   ` Sricharan R
2011-09-12 14:41     ` Trond Myklebust
2011-09-12 15:54       ` Trond Myklebust
2011-09-13  6:41         ` Sricharan R

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ef6baf9c7c0f44d1d50e3f65c6b038be@mail.gmail.com \
    --to=r.sricharan@ti.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).