public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Calum Mackay <calum.mackay@oracle.com>
To: Jeff Layton <jlayton@kernel.org>
Cc: Calum Mackay <calum.mackay@oracle.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH pynfs] CSESS22: increase the limit above latest knfsd limit
Date: Thu, 2 Jan 2025 20:27:40 +0000	[thread overview]
Message-ID: <f005d232-6855-4264-b053-785dd69f6542@oracle.com> (raw)
In-Reply-To: <20241220-master-v1-1-4627ad33175b@kernel.org>

On 20/12/2024 5:23 pm, Jeff Layton wrote:
> With the latest code in Chuck's nfsd-testing branch, the limit on the
> number of fore-channel session slots has been increased to 2048.
> Increase the TOO_MANY_SLOTS variable to 2049.
> 
> Signed-off-by: Jeff Layton <jlayton@kernel.org>
> ---
> Maybe we should increase this to a much higher number instead?  I half
> wonder if we ought to just eliminate this test altogether. It seems sort
> of arbitrary.
> ---

I've applied this as is, thanks Jeff; will have a further think about 
whether the test is still useful.

cheers,
c.


>   nfs4.1/server41tests/st_create_session.py | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/nfs4.1/server41tests/st_create_session.py b/nfs4.1/server41tests/st_create_session.py
> index 43166443ef6f86a6b44de70f3793bd93a330bc9d..740f8bf274c4eeb3ff9da20c0de241a31f80ac26 100644
> --- a/nfs4.1/server41tests/st_create_session.py
> +++ b/nfs4.1/server41tests/st_create_session.py
> @@ -395,7 +395,7 @@ def testMaxreqs(t, env):
>       """
>       # Assuming this is too large for any server; increase if necessary:
>       # but too huge will eat many memory for replay_cache, be careful!
> -    TOO_MANY_SLOTS = 500
> +    TOO_MANY_SLOTS = 2049
>   
>       c = env.c1.new_client(env.testname(t))
>       # CREATE_SESSION with fore_channel = TOO_MANY_SLOTS
> 
> ---
> base-commit: fa786a7217128e6e5c9ef20da9dd6069f5f593e7
> change-id: 20241220-master-2b43693225b0
> 
> Best regards,



      reply	other threads:[~2025-01-02 20:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-20 17:23 [PATCH pynfs] CSESS22: increase the limit above latest knfsd limit Jeff Layton
2025-01-02 20:27 ` Calum Mackay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f005d232-6855-4264-b053-785dd69f6542@oracle.com \
    --to=calum.mackay@oracle.com \
    --cc=jlayton@kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox