From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CAE4C04A6B for ; Mon, 13 May 2019 01:51:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 74900208C0 for ; Mon, 13 May 2019 01:51:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727132AbfEMBvD (ORCPT ); Sun, 12 May 2019 21:51:03 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7744 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727054AbfEMBvD (ORCPT ); Sun, 12 May 2019 21:51:03 -0400 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id C5890FD6C62FC409CD23; Mon, 13 May 2019 09:49:00 +0800 (CST) Received: from [127.0.0.1] (10.184.189.120) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.439.0; Mon, 13 May 2019 09:48:59 +0800 Subject: Re: [PATCH] SUNRPC: task should be exit if encode return EKEYEXPIRED more times From: "zhangxiaoxu (A)" To: , , , , , References: <1556530351-81780-1-git-send-email-zhangxiaoxu5@huawei.com> Message-ID: Date: Mon, 13 May 2019 09:48:49 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.184.189.120] X-CFilter-Loop: Reflected Sender: linux-nfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org ping. On 5/4/2019 2:15 PM, zhangxiaoxu (A) wrote: > ping. > > On 4/29/2019 5:32 PM, ZhangXiaoxu wrote: >> If the rpc.gssd always return cred success, but now the cred is >> expired, then the task will loop in call_refresh and call_transmit. >> >> Exit the rpc task after retry. >> >> Signed-off-by: ZhangXiaoxu >> --- >>   net/sunrpc/clnt.c | 9 ++++++++- >>   1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/net/sunrpc/clnt.c b/net/sunrpc/clnt.c >> index 8ff11dc..a32d3f1 100644 >> --- a/net/sunrpc/clnt.c >> +++ b/net/sunrpc/clnt.c >> @@ -1793,7 +1793,14 @@ call_encode(struct rpc_task *task) >>               rpc_delay(task, HZ >> 4); >>               break; >>           case -EKEYEXPIRED: >> -            task->tk_action = call_refresh; >> +            if (!task->tk_cred_retry) { >> +                rpc_exit(task, task->tk_status); >> +            } else { >> +                task->tk_action = call_refresh; >> +                task->tk_cred_retry--; >> +                dprintk("RPC: %5u %s: retry refresh creds\n", >> +                    task->tk_pid, __func__); >> +            } >>               break; >>           default: >>               rpc_exit(task, task->tk_status); >> > > > . >