From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B728910F7; Fri, 12 Jul 2024 10:16:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720779401; cv=none; b=AIqQupjBpjxBpMPVvtStmolYUoSUjGwTLrimA6psUphL5ivxz32RPGdgE2b71wOsRRergJ9bgR/dZS0KskaNqVh4NQYos2QC//W4JMNJQG/NrlQp0Ezp/0hWOhubrZtFz8VPtzps61xlCIIsW0VSca1pt2lPpocLQkiFAUUFv8g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720779401; c=relaxed/simple; bh=mh0swyd6XbUBdJOO8a4j8TNVvTeDM2OpRLb1t2gTakY=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=hS/UnaGuA9+nwW/dhwQ3eX/lMnuipPNngj+AhCqFXSRyn2Bkxgw0ifxzWEPrU21nhHR8Z/ThmqsMWpokqoYmniNKzT0u7fes5ZnNItEqpau6zKqrozf7mJGiATrG3P6GXYWoTF+2/9Jjb8Rr2YXbfm7xJHD8scV8zy5SAE2MrhQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=b4qKDswz; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="b4qKDswz" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 093CCC32782; Fri, 12 Jul 2024 10:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1720779401; bh=mh0swyd6XbUBdJOO8a4j8TNVvTeDM2OpRLb1t2gTakY=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=b4qKDswzZmTYk5KJNuolwpdUFN3nws816pktA7dbcn/AELsDC2LAGLQ6LtgnX9wqn cbXaUzv8C2RiHyUd/s0HZHLSSD1TjVsZaEyoXfHVJOASgFCrLXBG2kTvqu3f2KAtj2 L7Z8YeSTWWApuiNoPFW6cd0Dl2F0niBiKGmeMM/SAKFfQFVaVnYaEZxS2D5zrgtVGT jN8zg91jtd/0e1xumCFpJy7tSvGSBFN589X96PSe2EE369ObSWn3WTgvA0VVq3VQpI M13F5pd13oY6skBTrV+GVAzEKWECJM214Izd+edVz81rjO3bfDGmHgDVS8lUDBLVTN x4UThyNJ8yaaw== Message-ID: Subject: Re: [LTP] [PATCH 1/1] nfsstat01: Update client RPC calls for kernel 6.9 From: Jeff Layton To: NeilBrown Cc: Chuck Lever III , Greg KH , Sherry Yang , Calum Mackay , linux-stable , Petr Vorel , Trond Myklebust , Anna Schumaker , Linux NFS Mailing List , "kernel-team@fb.com" , "ltp@lists.linux.it" , Avinesh Kumar , Josef Bacik Date: Fri, 12 Jul 2024 06:16:38 -0400 In-Reply-To: <172076474233.15471.345629269384872391@noble.neil.brown.name> References: <>, <172076474233.15471.345629269384872391@noble.neil.brown.name> Autocrypt: addr=jlayton@kernel.org; prefer-encrypt=mutual; keydata=mQINBE6V0TwBEADXhJg7s8wFDwBMEvn0qyhAnzFLTOCHooMZyx7XO7dAiIhDSi7G1NPxw n8jdFUQMCR/GlpozMFlSFiZXiObE7sef9rTtM68ukUyZM4pJ9l0KjQNgDJ6Fr342Htkjxu/kFV1Wv egyjnSsFt7EGoDjdKqr1TS9syJYFjagYtvWk/UfHlW09X+jOh4vYtfX7iYSx/NfqV3W1D7EDi0PqV T2h6v8i8YqsATFPwO4nuiTmL6I40ZofxVd+9wdRI4Db8yUNA4ZSP2nqLcLtFjClYRBoJvRWvsv4lm 0OX6MYPtv76hka8lW4mnRmZqqx3UtfHX/hF/zH24Gj7A6sYKYLCU3YrI2Ogiu7/ksKcl7goQjpvtV YrOOI5VGLHge0awt7bhMCTM9KAfPc+xL/ZxAMVWd3NCk5SamL2cE99UWgtvNOIYU8m6EjTLhsj8sn VluJH0/RcxEeFbnSaswVChNSGa7mXJrTR22lRL6ZPjdMgS2Km90haWPRc8Wolcz07Y2se0xpGVLEQ cDEsvv5IMmeMe1/qLZ6NaVkNuL3WOXvxaVT9USW1+/SGipO2IpKJjeDZfehlB/kpfF24+RrK+seQf CBYyUE8QJpvTZyfUHNYldXlrjO6n5MdOempLqWpfOmcGkwnyNRBR46g/jf8KnPRwXs509yAqDB6sE LZH+yWr9LQZEwARAQABtCVKZWZmIExheXRvbiA8amxheXRvbkBwb29jaGllcmVkcy5uZXQ+iQI7BB MBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAUCTpXWPAIZAQAKCRAADmhBGVaCFc65D/4 gBLNMHopQYgG/9RIM3kgFCCQV0pLv0hcg1cjr+bPI5f1PzJoOVi9s0wBDHwp8+vtHgYhM54yt43uI 7Htij0RHFL5eFqoVT4TSfAg2qlvNemJEOY0e4daljjmZM7UtmpGs9NN0r9r50W82eb5Kw5bc/r0km R/arUS2st+ecRsCnwAOj6HiURwIgfDMHGPtSkoPpu3DDp/cjcYUg3HaOJuTjtGHFH963B+f+hyQ2B rQZBBE76ErgTDJ2Db9Ey0kw7VEZ4I2nnVUY9B5dE2pJFVO5HJBMp30fUGKvwaKqYCU2iAKxdmJXRI ONb7dSde8LqZahuunPDMZyMA5+mkQl7kpIpR6kVDIiqmxzRuPeiMP7O2FCUlS2DnJnRVrHmCljLkZ Wf7ZUA22wJpepBligemtSRSbqCyZ3B48zJ8g5B8xLEntPo/NknSJaYRvfEQqGxgk5kkNWMIMDkfQO lDSXZvoxqU9wFH/9jTv1/6p8dHeGM0BsbBLMqQaqnWiVt5mG92E1zkOW69LnoozE6Le+12DsNW7Rj iR5K+27MObjXEYIW7FIvNN/TQ6U1EOsdxwB8o//Yfc3p2QqPr5uS93SDDan5ehH59BnHpguTc27Xi QQZ9EGiieCUx6Zh2ze3X2UW9YNzE15uKwkkuEIj60NvQRmEDfweYfOfPVOueC+iFifbQgSmVmZiBM YXl0b24gPGpsYXl0b25AcmVkaGF0LmNvbT6JAjgEEwECACIFAk6V0q0CGwMGCwkIBwMCBhUIAgkKC wQWAgMBAh4BAheAAAoJEAAOaEEZVoIViKUQALpvsacTMWWOd7SlPFzIYy2/fjvKlfB/Xs4YdNcf9q LqF+lk2RBUHdR/dGwZpvw/OLmnZ8TryDo2zXVJNWEEUFNc7wQpl3i78r6UU/GUY/RQmOgPhs3epQC 3PMJj4xFx+VuVcf/MXgDDdBUHaCTT793hyBeDbQuciARDJAW24Q1RCmjcwWIV/pgrlFa4lAXsmhoa c8UPc82Ijrs6ivlTweFf16VBc4nSLX5FB3ls7S5noRhm5/Zsd4PGPgIHgCZcPgkAnU1S/A/rSqf3F LpU+CbVBDvlVAnOq9gfNF+QiTlOHdZVIe4gEYAU3CUjbleywQqV02BKxPVM0C5/oVjMVx3bri75n1 TkBYGmqAXy9usCkHIsG5CBHmphv9MHmqMZQVsxvCzfnI5IO1+7MoloeeW/lxuyd0pU88dZsV/riHw 87i2GJUJtVlMl5IGBNFpqoNUoqmvRfEMeXhy/kUX4Xc03I1coZIgmwLmCSXwx9MaCPFzV/dOOrju2 xjO+2sYyB5BNtxRqUEyXglpujFZqJxxau7E0eXoYgoY9gtFGsspzFkVNntamVXEWVVgzJJr/EWW0y +jNd54MfPRqH+eCGuqlnNLktSAVz1MvVRY1dxUltSlDZT7P2bUoMorIPu8p7ZCg9dyX1+9T6Muc5d Hxf/BBP/ir+3e8JTFQBFOiLNdFtB9KZWZmIExheXRvbiA8amxheXRvbkBzYW1iYS5vcmc+iQI4BBM BAgAiBQJOldK9AhsDBgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRAADmhBGVaCFWgWD/0ZRi4h N9FK2BdQs9RwNnFZUr7JidAWfCrs37XrA/56olQl3ojn0fQtrP4DbTmCuh0SfMijB24psy1GnkPep naQ6VRf7Dxg/Y8muZELSOtsv2CKt3/02J1BBitrkkqmHyni5fLLYYg6fub0T/8Kwo1qGPdu1hx2BQ RERYtQ/S5d/T0cACdlzi6w8rs5f09hU9Tu4qV1JLKmBTgUWKN969HPRkxiojLQziHVyM/weR5Reu6 FZVNuVBGqBD+sfk/c98VJHjsQhYJijcsmgMb1NohAzwrBKcSGKOWJToGEO/1RkIN8tqGnYNp2G+aR 685D0chgTl1WzPRM6mFG1+n2b2RR95DxumKVpwBwdLPoCkI24JkeDJ7lXSe3uFWISstFGt0HL8Eew P8RuGC8s5h7Ct91HMNQTbjgA+Vi1foWUVXpEintAKgoywaIDlJfTZIl6Ew8ETN/7DLy8bXYgq0Xzh aKg3CnOUuGQV5/nl4OAX/3jocT5Cz/OtAiNYj5mLPeL5z2ZszjoCAH6caqsF2oLyAnLqRgDgR+wTQ T6gMhr2IRsl+cp8gPHBwQ4uZMb+X00c/Amm9VfviT+BI7B66cnC7Zv6Gvmtu2rEjWDGWPqUgccB7h dMKnKDthkA227/82tYoFiFMb/NwtgGrn5n2vwJyKN6SEoygGrNt0SI84y6hEVbQlSmVmZiBMYXl0b 24gPGpsYXl0b25AcHJpbWFyeWRhdGEuY29tPokCOQQTAQIAIwUCU4xmKQIbAwcLCQgHAwIBBhUIAg kKCwQWAgMBAh4BAheAAAoJEAAOaEEZVoIV1H0P/j4OUTwFd7BBbpoSp695qb6HqCzWMuExsp8nZjr uymMaeZbGr3OWMNEXRI1FWNHMtcMHWLP/RaDqCJil28proO+PQ/yPhsr2QqJcW4nr91tBrv/MqItu AXLYlsgXqp4BxLP67bzRJ1Bd2x0bWXurpEXY//VBOLnODqThGEcL7jouwjmnRh9FTKZfBDpFRaEfD FOXIfAkMKBa/c9TQwRpx2DPsl3eFWVCNuNGKeGsirLqCxUg5kWTxEorROppz9oU4HPicL6rRH22Ce 6nOAON2vHvhkUuO3GbffhrcsPD4DaYup4ic+DxWm+DaSSRJ+e1yJvwi6NmQ9P9UAuLG93S2MdNNbo sZ9P8k2mTOVKMc+GooI9Ve/vH8unwitwo7ORMVXhJeU6Q0X7zf3SjwDq2lBhn1DSuTsn2DbsNTiDv qrAaCvbsTsw+SZRwF85eG67eAwouYk+dnKmp1q57LDKMyzysij2oDKbcBlwB/TeX16p8+LxECv51a sjS9TInnipssssUDrHIvoTTXWcz7Y5wIngxDFwT8rPY3EggzLGfK5Zx2Q5S/N0FfmADmKknG/D8qG IcJE574D956tiUDKN4I+/g125ORR1v7bP+OIaayAvq17RP+qcAqkxc0x8iCYVCYDouDyNvWPGRhbL UO7mlBpjW9jK9e2fvZY9iw3QzIPGKtClKZWZmIExheXRvbiA8amVmZi5sYXl0b25AcHJpbWFyeWRh dGEuY29tPokCOQQTAQIAIwUCU4xmUAIbAwcLCQgHAwIBBhUIAgkKCwQWAgMBAh4BAheAAAoJEAAOa EEZVoIVzJoQALFCS6n/FHQS+hIzHIb56JbokhK0AFqoLVzLKzrnaeXhE5isWcVg0eoV2oTScIwUSU apy94if69tnUo4Q7YNt8/6yFM6hwZAxFjOXR0ciGE3Q+Z1zi49Ox51yjGMQGxlakV9ep4sV/d5a50 M+LFTmYSAFp6HY23JN9PkjVJC4PUv5DYRbOZ6Y1+TfXKBAewMVqtwT1Y+LPlfmI8dbbbuUX/kKZ5d dhV2736fgyfpslvJKYl0YifUOVy4D1G/oSycyHkJG78OvX4JKcf2kKzVvg7/Rnv+AueCfFQ6nGwPn 0P91I7TEOC4XfZ6a1K3uTp4fPPs1Wn75X7K8lzJP/p8lme40uqwAyBjk+IA5VGd+CVRiyJTpGZwA0 jwSYLyXboX+Dqm9pSYzmC9+/AE7lIgpWj+3iNisp1SWtHc4pdtQ5EU2SEz8yKvDbD0lNDbv4ljI7e flPsvN6vOrxz24mCliEco5DwhpaaSnzWnbAPXhQDWb/lUgs/JNk8dtwmvWnqCwRqElMLVisAbJmC0 BhZ/Ab4sph3EaiZfdXKhiQqSGdK4La3OTJOJYZphPdGgnkvDV9Pl1QZ0ijXQrVIy3zd6VCNaKYq7B AKidn5g/2Q8oio9Tf4XfdZ9dtwcB+bwDJFgvvDYaZ5bI3ln4V3EyW5i2NfXazz/GA/I/ZtbsigCFc 8ftCBKZWZmIExheXRvbiA8amxheXRvbkBrZXJuZWwub3JnPokCOAQTAQIAIgUCWe8u6AIbAwYLCQg HAwIGFQgCCQoLBBYCAwECHgECF4AACgkQAA5oQRlWghUuCg/+Lb/xGxZD2Q1oJVAE37uW308UpVSD 2tAMJUvFTdDbfe3zKlPDTuVsyNsALBGclPLagJ5ZTP+Vp2irAN9uwBuacBOTtmOdz4ZN2tdvNgozz uxp4CHBDVzAslUi2idy+xpsp47DWPxYFIRP3M8QG/aNW052LaPc0cedYxp8+9eiVUNpxF4SiU4i9J DfX/sn9XcfoVZIxMpCRE750zvJvcCUz9HojsrMQ1NFc7MFT1z3MOW2/RlzPcog7xvR5ENPH19ojRD CHqumUHRry+RF0lH00clzX/W8OrQJZtoBPXv9ahka/Vp7kEulcBJr1cH5Wz/WprhsIM7U9pse1f1g Yy9YbXtWctUz8uvDR7shsQxAhX3qO7DilMtuGo1v97I/Kx4gXQ52syh/w6EBny71CZrOgD6kJwPVV AaM1LRC28muq91WCFhs/nzHozpbzcheyGtMUI2Ao4K6mnY+3zIuXPygZMFr9KXE6fF7HzKxKuZMJO aEZCiDOq0anx6FmOzs5E6Jqdpo/mtI8beK+BE7Va6ni7YrQlnT0i3vaTVMTiCThbqsB20VrbMjlhp f8lfK1XVNbRq/R7GZ9zHESlsa35ha60yd/j3pu5hT2xyy8krV8vGhHvnJ1XRMJBAB/UYb6FyC7S+m QZIQXVeAA+smfTT0tDrisj1U5x6ZB9b3nBg65kc= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.52.2 (3.52.2-1.fc40app2) Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Fri, 2024-07-12 at 16:12 +1000, NeilBrown wrote: > On Fri, 12 Jul 2024, Jeff Layton wrote: > > On Fri, 2024-07-12 at 08:58 +1000, NeilBrown wrote: > > > On Fri, 12 Jul 2024, Jeff Layton wrote: > > > > On Mon, 2024-07-08 at 17:49 +0000, Chuck Lever III wrote: > > > > >=20 > > > > > > On Jul 8, 2024, at 6:36=E2=80=AFAM, Greg KH wr= ote: > > > > > >=20 > > > > > > On Sat, Jul 06, 2024 at 07:46:19AM +0000, Sherry Yang wrote: > > > > > > >=20 > > > > > > >=20 > > > > > > > > On Jul 6, 2024, at 12:11=E2=80=AFAM, Greg KH wrote: > > > > > > > >=20 > > > > > > > > On Fri, Jul 05, 2024 at 02:19:18PM +0000, Chuck Lever III w= rote: > > > > > > > > >=20 > > > > > > > > >=20 > > > > > > > > > > On Jul 2, 2024, at 6:55=E2=80=AFPM, Calum Mackay wrote: > > > > > > > > > >=20 > > > > > > > > > > To clarify=E2=80=A6 > > > > > > > > > >=20 > > > > > > > > > > On 02/07/2024 5:54 pm, Calum Mackay wrote: > > > > > > > > > > > hi Petr, > > > > > > > > > > > I noticed your LTP patch [1][2] which adjusts the nfs= stat01 test on v6.9 kernels, to account for Josef's changes [3], which rest= rict the NFS/RPC stats per-namespace. > > > > > > > > > > > I see that Josef's changes were backported, as far ba= ck as longterm v5.4, > > > > > > > > > >=20 > > > > > > > > > > Sorry, that's not quite accurate. > > > > > > > > > >=20 > > > > > > > > > > Josef's NFS client changes were all backported from v6.= 9, as far as longterm v5.4.y: > > > > > > > > > >=20 > > > > > > > > > > 2057a48d0dd0 sunrpc: add a struct rpc_stats arg to rpc_= create_args > > > > > > > > > > d47151b79e32 nfs: expose /proc/net/sunrpc/nfs in net na= mespaces > > > > > > > > > > 1548036ef120 nfs: make the rpc_stat per net namespace > > > > > > > > > >=20 > > > > > > > > > >=20 > > > > > > > > > > Of Josef's NFS server changes, four were backported fro= m v6.9 to v6.8: > > > > > > > > > >=20 > > > > > > > > > > 418b9687dece sunrpc: use the struct net as the svc proc= private > > > > > > > > > > d98416cc2154 nfsd: rename NFSD_NET_* to NFSD_STATS_* > > > > > > > > > > 93483ac5fec6 nfsd: expose /proc/net/sunrpc/nfsd in net = namespaces > > > > > > > > > > 4b14885411f7 nfsd: make all of the nfsd stats per-netwo= rk namespace > > > > > > > > > >=20 > > > > > > > > > > and the others remained only in v6.9: > > > > > > > > > >=20 > > > > > > > > > > ab42f4d9a26f sunrpc: don't change ->sv_stats if it does= n't exist > > > > > > > > > > a2214ed588fb nfsd: stop setting ->pg_stats for unused s= tats > > > > > > > > > > f09432386766 sunrpc: pass in the sv_stats struct throug= h svc_create_pooled > > > > > > > > > > 3f6ef182f144 sunrpc: remove ->pg_stats from svc_program > > > > > > > > > > e41ee44cc6a4 nfsd: remove nfsd_stats, make th_cnt a glo= bal counter > > > > > > > > > > 16fb9808ab2c nfsd: make svc_stat per-network namespace = instead of global > > > > > > > > > >=20 > > > > > > > > > >=20 > > > > > > > > > >=20 > > > > > > > > > > I'm wondering if this difference between NFS client, an= d NFS server, stat behaviour, across kernel versions, may perhaps cause som= e user confusion? > > > > > > > > >=20 > > > > > > > > > As a refresher for the stable folken, Josef's changes mak= e > > > > > > > > > nfsstats silo'd, so they no longer show counts from the w= hole > > > > > > > > > system, but only for NFS operations relating to the local= net > > > > > > > > > namespace. That is a surprising change for some users, to= ols, > > > > > > > > > and testing. > > > > > > > > >=20 > > > > > > > > > I'm not clear on whether there are any rules/guidelines a= round > > > > > > > > > LTS backports causing behavior changes that user tools, l= ike > > > > > > > > > nfsstat, might be impacted by. > > > > > > > >=20 > > > > > > > > The same rules that apply for Linus's tree (i.e. no userspa= ce > > > > > > > > regressions.) > > > > > > >=20 > > > > > > > Given the current data we have, LTP nfsstat01[1] failed on LT= S v5.4.278 because of kernel commit 1548036ef1204 ("nfs: > > > > > > > make the rpc_stat per net namespace") [2]. Other LTS which ba= ckported the same commit are very likely troubled with the same LTP test fa= ilure. > > > > > > >=20 > > > > > > > The following are the LTP nfsstat01 failure output > > > > > > >=20 > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D > > > > > > > network 1 TINFO: initialize 'lhost' 'ltp_ns_veth2' interface > > > > > > > network 1 TINFO: add local addr 10.0.0.2/24 > > > > > > > network 1 TINFO: add local addr fd00:1:1:1::2/64 > > > > > > > network 1 TINFO: initialize 'rhost' 'ltp_ns_veth1' interface > > > > > > > network 1 TINFO: add remote addr 10.0.0.1/24 > > > > > > > network 1 TINFO: add remote addr fd00:1:1:1::1/64 > > > > > > > network 1 TINFO: Network config (local -- remote): > > > > > > > network 1 TINFO: ltp_ns_veth2 -- ltp_ns_veth1 > > > > > > > network 1 TINFO: 10.0.0.2/24 -- 10.0.0.1/24 > > > > > > > network 1 TINFO: fd00:1:1:1::2/64 -- fd00:1:1:1::1/64 > > > > > > > <<>> > > > > > > > tag=3Dveth|nfsstat3_01 stime=3D1719943586 > > > > > > > cmdline=3D"nfsstat01" > > > > > > > contacts=3D"" > > > > > > > analysis=3Dexit > > > > > > > <<>> > > > > > > > incrementing stop > > > > > > > nfsstat01 1 TINFO: timeout per run is 0h 20m 0s > > > > > > > nfsstat01 1 TINFO: setup NFSv3, socket type udp > > > > > > > nfsstat01 1 TINFO: Mounting NFS: mount -t nfs -o proto=3Dudp,= vers=3D3 10.0.0.2:/tmp/netpan-4577/LTP_nfsstat01.lz6zhgQHoV/3/udp /tmp/netp= an-4577/LTP_nfsstat01.lz6zhgQHoV/3/0 > > > > > > > nfsstat01 1 TINFO: checking RPC calls for server/client > > > > > > > nfsstat01 1 TINFO: calls 98/0 > > > > > > > nfsstat01 1 TINFO: Checking for tracking of RPC calls for ser= ver/client > > > > > > > nfsstat01 1 TINFO: new calls 102/0 > > > > > > > nfsstat01 1 TPASS: server RPC calls increased > > > > > > > nfsstat01 1 TFAIL: client RPC calls not increased > > > > > > > nfsstat01 1 TINFO: checking NFS calls for server/client > > > > > > > nfsstat01 1 TINFO: calls 2/2 > > > > > > > nfsstat01 1 TINFO: Checking for tracking of NFS calls for ser= ver/client > > > > > > > nfsstat01 1 TINFO: new calls 3/3 > > > > > > > nfsstat01 1 TPASS: server NFS calls increased > > > > > > > nfsstat01 1 TPASS: client NFS calls increased > > > > > > > nfsstat01 2 TINFO: Cleaning up testcase > > > > > > > nfsstat01 2 TINFO: SELinux enabled in enforcing mode, this ma= y affect test results > > > > > > > nfsstat01 2 TINFO: it can be disabled with TST_DISABLE_SELINU= X=3D1 (requires super/root) > > > > > > > nfsstat01 2 TINFO: install seinfo to find used SELinux profil= es > > > > > > > nfsstat01 2 TINFO: loaded SELinux profiles: none > > > > > > >=20 > > > > > > > Summary: > > > > > > > passed 3 > > > > > > > failed 1 > > > > > > > skipped 0 > > > > > > > warnings 0 > > > > > > > <<>> > > > > > > > initiation_status=3D"ok" > > > > > > > duration=3D1 termination_type=3Dexited termination_id=3D1 cor= efile=3Dno > > > > > > > cutime=3D11 cstime=3D16 > > > > > > > <<>> > > > > > > > ltp-pan reported FAIL > > > > > > > =3D=3D=3D=3D=3D=3D=3D=3D > > > > > > >=20 > > > > > > > We can observe the number of RPC client calls is 0, which is = wired. And this happens from the kernel commit 57d1ce96d7655 ("nfs: make th= e rpc_stat per net namespace=E2=80=9D). So now we=E2=80=99re not sure the k= ernel backport of nfs client changes is proper, or the LTP tests / userspac= e need to be modified. > > > > > > >=20 > > > > > > > If no userspace regression, should we revert the Josef=E2=80= =99s NFS client-side changes on LTS? > > > > > >=20 > > > > > > This sounds like a regression in Linus's tree too, so why isn't= it > > > > > > reverted there first? > > > > >=20 > > > > > There is a change in behavior in the upstream code, but Josef's > > > > > patches fix an information leak and make the statistics more > > > > > sensible in container environments. I'm not certain that > > > > > should be considered a regression, but confess I don't know > > > > > the regression rules to this fine a degree of detail. > > > > >=20 > > > > > If it is indeed a regression, how can we go about retaining > > > > > both behaviors (selectable by Kconfig or perhaps administrative > > > > > UI)? > > > > >=20 > > > >=20 > > > > I'd argue that the old behavior was a bug, and that Josef fixed > > > > it.=C2=A0These stats should probably have been made per-net when al= l of the > > > > original nfsd namespace work was done, but no one noticed until > > > > recently. Whoops.=C2=A0 > > > >=20 > > > > A couple of hacky ideas for how we might deal with this: > > > >=20 > > > > 1/ add a new line to the output of /proc/net/rpc/nfsd. It could jus= t > > > > say "per-net\n" or "per-net \n" or something. nfss= tat > > > > should ignore it, but LTP test could look for it and handle it > > > > appropriately. That could even be useful later for nfsstat too I gu= ess. > > > >=20 > > > > 2/ move the file to a new name and make the old filename be a symli= nk > > > > to the new one. nfsstat would still work, but LTP would be able to = see > > > > whether it was a symlink to detect the difference...or could just m= ake > > > > a new symlink that points to the file and LTP could look for its > > > > presence. > > >=20 > > > I don't think it makes sense to present a solution which requires > > > LTP to be modified. If we are willing to modify LTP, then we should > > > modify it to work with the per-net stats. > > >=20 > > > I think we need to create a new interface for the per-net stats, then > > > deprecate the old interface and remove it in (say) 2 years. That giv= en > > > LTP time to update, and means that an old LTP won't give incorrect > > > numbers, it will simply fail. > > >=20 > > > All we need to do is bikeshed the new interface. > > > netlink ? > > > /proc/net/rpc-pernet/nfsd ? > > >=20 > > > This means that we still need to keep the combined stats, or to combi= ne > > > all the per-net stats on each access. > > >=20 > >=20 > > How much of this functionality would we need to restore? > >=20 > > Prior to Josef's patches, you would get info about global stats from > > relevant stats procfiles in a container. That seems like an information > > leak to me, but fixing that is probably going to break _somebody_. > > Where do we draw the line and why? > >=20 > > LTP is just a testsuite. Asking them to alter tests in order to cope > > with a bugfix seems entirely reasonable to me. If someone can make a > > case for real-world applications that rely on the old semantics, then > > I'd be more open to changing this, but I just don't see the upside of > > restoring legacy behavior here. >=20 > If it is OK to ask them to alter the tests, ask them to alter the tests > to work with today's kernel and don't make any change to the kernel. > Maybe the tests will have to be fixed to "PASS" both the old and the new > results, but that probably isn't rocket science. >=20 > My point is that if we are going to change the kernel to accommodate LTP > at all, we should accommodate LTP as it is today. If we are going to > change LTP to accommodate the kernel, then it should accommodate the > kernel as it is today. >=20 The problem is that there is no way for userland tell the difference between the older and newer behavior. That was what I was suggesting we add. To be clear, I hold this opinion loosely. If the consensus is that we need to revert things then so be it. I just don't see the value of doing that in this particular situation. --=20 Jeff Layton