linux-nfs.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Steve Dickson <SteveD@RedHat.com>
To: Frank Sorenson <sorenson@redhat.com>, linux-nfs@vger.kernel.org
Subject: Re: [PATCH RFC] nfs-utils: mount: handle EACCES during version negotiation
Date: Thu, 14 Sep 2017 13:11:33 -0400	[thread overview]
Message-ID: <f85953dd-c2eb-f6c7-d3d1-297be6b1b39e@RedHat.com> (raw)
In-Reply-To: <279c0751-8284-5289-3407-129dc9c9d3e8@redhat.com>



On 09/07/2017 11:14 AM, Frank Sorenson wrote:
> mount() can return EACCES for servers which permit 4.0
> but are configured not to allow 4.1  This is currently
> only handled by the default case, so these mounts fail
> without retrying a lower minor.
> 
> Add handling for EACCES to be retried with a lower
> minor version.
> 
> Signed-off-by: Frank Sorenson <sorenson@redhat.com>
Committed... 

steved.
> ---
>  utils/mount/stropts.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 1d30d34..4401314 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -862,6 +862,9 @@ check_result:
>  	case EINVAL:
>  		/* A less clear indication that our client
>  		 * does not support NFSv4 minor version. */
> +	case EACCES:
> +		/* An unclear indication that the server
> +		 * may not support NFSv4 minor version. */
>  		if (mi->version.v_mode != V_SPECIFIC) {
>  			if (mi->version.minor > 0) {
>  				mi->version.minor--;
> 

      reply	other threads:[~2017-09-14 17:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-09-07 15:14 [PATCH RFC] nfs-utils: mount: handle EACCES during version negotiation Frank Sorenson
2017-09-14 17:11 ` Steve Dickson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f85953dd-c2eb-f6c7-d3d1-297be6b1b39e@RedHat.com \
    --to=steved@redhat.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=sorenson@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).