* [PATCH RFC] nfs-utils: mount: handle EACCES during version negotiation
@ 2017-09-07 15:14 Frank Sorenson
2017-09-14 17:11 ` Steve Dickson
0 siblings, 1 reply; 2+ messages in thread
From: Frank Sorenson @ 2017-09-07 15:14 UTC (permalink / raw)
To: linux-nfs
mount() can return EACCES for servers which permit 4.0
but are configured not to allow 4.1 This is currently
only handled by the default case, so these mounts fail
without retrying a lower minor.
Add handling for EACCES to be retried with a lower
minor version.
Signed-off-by: Frank Sorenson <sorenson@redhat.com>
---
utils/mount/stropts.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
index 1d30d34..4401314 100644
--- a/utils/mount/stropts.c
+++ b/utils/mount/stropts.c
@@ -862,6 +862,9 @@ check_result:
case EINVAL:
/* A less clear indication that our client
* does not support NFSv4 minor version. */
+ case EACCES:
+ /* An unclear indication that the server
+ * may not support NFSv4 minor version. */
if (mi->version.v_mode != V_SPECIFIC) {
if (mi->version.minor > 0) {
mi->version.minor--;
--
2.13.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH RFC] nfs-utils: mount: handle EACCES during version negotiation
2017-09-07 15:14 [PATCH RFC] nfs-utils: mount: handle EACCES during version negotiation Frank Sorenson
@ 2017-09-14 17:11 ` Steve Dickson
0 siblings, 0 replies; 2+ messages in thread
From: Steve Dickson @ 2017-09-14 17:11 UTC (permalink / raw)
To: Frank Sorenson, linux-nfs
On 09/07/2017 11:14 AM, Frank Sorenson wrote:
> mount() can return EACCES for servers which permit 4.0
> but are configured not to allow 4.1 This is currently
> only handled by the default case, so these mounts fail
> without retrying a lower minor.
>
> Add handling for EACCES to be retried with a lower
> minor version.
>
> Signed-off-by: Frank Sorenson <sorenson@redhat.com>
Committed...
steved.
> ---
> utils/mount/stropts.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/utils/mount/stropts.c b/utils/mount/stropts.c
> index 1d30d34..4401314 100644
> --- a/utils/mount/stropts.c
> +++ b/utils/mount/stropts.c
> @@ -862,6 +862,9 @@ check_result:
> case EINVAL:
> /* A less clear indication that our client
> * does not support NFSv4 minor version. */
> + case EACCES:
> + /* An unclear indication that the server
> + * may not support NFSv4 minor version. */
> if (mi->version.v_mode != V_SPECIFIC) {
> if (mi->version.minor > 0) {
> mi->version.minor--;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-09-14 17:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-09-07 15:14 [PATCH RFC] nfs-utils: mount: handle EACCES during version negotiation Frank Sorenson
2017-09-14 17:11 ` Steve Dickson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).