[PATCH 2/2] [pynfs] fix nfs4.1/use_local.py && add symlink nfs4.0/use_local.py

[PATCH 2/2] [pynfs] fix nfs4.1/use_local.py && add symlink nfs4.0/use_local.py

[Jianhong.Yin]

---
 nfs4.0/use_local.py | 1 +
 nfs4.1/use_local.py | 4 +---
 2 files changed, 2 insertions(+), 3 deletions(-)
 create mode 120000 nfs4.0/use_local.py

diff --git a/nfs4.0/use_local.py b/nfs4.0/use_local.py
new file mode 120000
index 0000000..3c3ddc2
--- /dev/null
+++ b/nfs4.0/use_local.py
@@ -0,0 +1 @@
+../nfs4.1/use_local.py
\ No newline at end of file
diff --git a/nfs4.1/use_local.py b/nfs4.1/use_local.py
index 3dbb0b2..9a1dcaa 100644
--- a/nfs4.1/use_local.py
+++ b/nfs4.1/use_local.py
@@ -4,9 +4,7 @@ from os.path import join, split
 cwd = os.getcwd()
 if True or cwd not in sys.path:
     head, tail = split(cwd)
-    dirs = [ join(head, "gssapi"),
-             join(head, "xdr"),
-             join(head, "ply"),
+    dirs = [ join(head, "xdr"),
              join(head), # rpc
              cwd,
              ]
-- 
2.14.3

Re: [PATCH 1/2] [pynfs] remove redundant ply, gssapi and rpcgen.py modules

[J. Bruce Fields]

On Wed, Mar 28, 2018 at 01:27:08AM +0800, Jianhong.Yin wrote:
> +Install dependent modules:
> +	#Fedora: yum install krb5-devel python-devel swig python-pip
> +	#Debian: apt-get install libkrb5-dev python-dev swig python-pip
> +	pip install ply gssapi

I've never used pip.  Googling around, I see some people warn about
potential conflicts between pip and rpm/dpkg.  Would it be better to
recommend pip install --user?

Anyway, looks better than carrying our own copy around.  Applying,
thanks!

--b.

Re: [PATCH 1/2] [pynfs] remove redundant ply, gssapi and rpcgen.py modules

[Patrick Goetz]

On 03/27/2018 01:37 PM, J. Bruce Fields wrote:
> I've never used pip.  Googling around, I see some people warn about
> potential conflicts between pip and rpm/dpkg.  Would it be better to
> recommend pip install --user?
> 


Pip is just the python package installer, similar to install.packages() 
in R or cpan in perl.

The issue with rpm/dpkg/pacman is that the distribution package manager 
won't know about anything that you've installed using pip, which could 
mean, for example, that you've met a library dependency using pip, but 
apt or yum insist that the library is missing and needs to be installed.

Re: [PATCH 1/2] [pynfs] remove redundant ply, gssapi and rpcgen.py modules

[J. Bruce Fields]

On Tue, Mar 27, 2018 at 02:24:00PM -0500, Patrick Goetz wrote:
> On 03/27/2018 01:37 PM, J. Bruce Fields wrote:
> >I've never used pip.  Googling around, I see some people warn about
> >potential conflicts between pip and rpm/dpkg.  Would it be better to
> >recommend pip install --user?
> 
> Pip is just the python package installer, similar to
> install.packages() in R or cpan in perl.
> 
> The issue with rpm/dpkg/pacman is that the distribution package
> manager won't know about anything that you've installed using pip,
> which could mean, for example, that you've met a library dependency
> using pip, but apt or yum insist that the library is missing and
> needs to be installed.

Any reason not to change the README to recommend

	pip install --user ply gssapi

? Seems like the safer default.

Actually now that I look my Fedora 27 laptop has both python-gssapi and
python-ply packages, so maybe there's no need for pip.

--b.

Re: [PATCH 1/2] [pynfs] remove redundant ply, gssapi and rpcgen.py modules

[Patrick Goetz]

On 03/27/2018 02:32 PM, J. Bruce Fields wrote:
> Any reason not to change the README to recommend
> 
> 	pip install --user ply gssapi
> 
> ? Seems like the safer default.
> 

I'm not sure why you have a --user in there; this would be used to 
install packages for a specific user AFAIK.

Re: [PATCH 1/2] [pynfs] remove redundant ply, gssapi and rpcgen.py modules

[Jianhong Yin]

Good to know.
will update README to inform users: they could use any/different methods to install these modules.

Thanks!

----- 原始邮件 -----
> 发件人: "J. Bruce Fields" <bfields@fieldses.org>
> 收件人: "Jianhong.Yin" <yin-jianhong@163.com>
> 抄送: bfields@redhat.com, linux-nfs@vger.kernel.org, "Jianhong Yin" <jiyin@redhat.com>
> 发送时间: 星期三, 2018年 3 月 28日 上午 2:37:25
> 主题: Re: [PATCH 1/2] [pynfs] remove redundant ply, gssapi and rpcgen.py modules
> 
> On Wed, Mar 28, 2018 at 01:27:08AM +0800, Jianhong.Yin wrote:
> > +Install dependent modules:
> > +	#Fedora: yum install krb5-devel python-devel swig python-pip
> > +	#Debian: apt-get install libkrb5-dev python-dev swig python-pip
> > +	pip install ply gssapi
> 
> I've never used pip.  Googling around, I see some people warn about
> potential conflicts between pip and rpm/dpkg.  Would it be better to
> recommend pip install --user?
> 
> Anyway, looks better than carrying our own copy around.  Applying,
> thanks!
> 
> --b.
>