Linux NFS development
 help / color / mirror / Atom feed
From: dai.ngo@oracle.com
To: brauner@kernel.org, Jorge Mora <Jorge.Mora@netapp.com>
Cc: "linux-nfs@vger.kernel.org" <linux-nfs@vger.kernel.org>,
	linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: nfstest_posix failed with 6.7 kernel (resend)
Date: Mon, 15 Jan 2024 13:05:37 -0800	[thread overview]
Message-ID: <feef41c7-b640-4616-908f-9d8eb97904aa@oracle.com> (raw)

(resend with correct Jorge Mora address)

The 'open' tests of nfstest_posix failed with 6.7 kernel with these errors:

     FAIL: open - opening existent file should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)
     FAIL: open - opening symbolic link should return an error when O_EXCL|O_CREAT is used (256 passed, 256 failed)

The problem can be reproduced with both client and server running
6.7 kernel.

Bisecting points to commit 43b450632676:
43b450632676: open: return EINVAL for O_DIRECTORY | O_CREAT

This commit was introduced in 6.4-rc1 and back ported to LTS kernels.
I'm not sure if the fix for this should be in the fs or in nfstest_posix.
The commit 43b450632676 makes sense to me. No one should expect open(2)
to create the directory so the error returned should be EINVAL instead of
EEXIST as nfstest_posix expects.

-Dai



             reply	other threads:[~2024-01-15 21:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-15 21:05 dai.ngo [this message]
2024-01-15 21:14 ` nfstest_posix failed with 6.7 kernel (resend) Matthew Wilcox
2024-01-15 21:24   ` dai.ngo
2024-01-16  9:25 ` Christian Brauner
2024-01-16 20:51   ` dai.ngo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=feef41c7-b640-4616-908f-9d8eb97904aa@oracle.com \
    --to=dai.ngo@oracle.com \
    --cc=Jorge.Mora@netapp.com \
    --cc=brauner@kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox